Description of problem:

1)

Starting with version 2.4.4 the plugin script check_log creates $templog    ${TMPDIR}/temp_check_log.XXXXXXXXXX     starting at line 214.

This temp file is copied to from the target log like /var/log/messages.

cp "$logfile" "$templog"
logfile=$templog

And used for a diff.

diff "$logfile" "$oldlog" | grep -v "^>" > "$tempdiff"

After getting what’s needed, $tempdiff is cleaned up and $oldlog replaced.

rm -f "$tempdiff"
cat "$logfile" > "$oldlog"

This leaves the temp file      $logfile    ${TMPDIR}/temp_check_log.XXXXXXXXXX       behind which has been filling my /tmp folders.   If I missed something let me know, but I suspect this temp file, new in 2.4.4 should be deleted after the cat.  Or change the cat to mv.


2) 

Also check_log v2.4.4 line 209….

echo "$TMPDIR"

…trips up the GUI display.  Looks like a testing comment that needs to be removed.




Version-Release number of selected component (if applicable): 

nagios-plugins-log.x86_64  2.4.4-1.el9


How reproducible: 

/usr/lib64/nagios/plugins/check_log   -F /var/log/messages -O /tmp/messages.nagios -q NOTICE



Steps to Reproduce:
1.
2.
3.

Actual results:



Expected results:


Additional info: