Bug 2224759

Summary: Review Request: rust-lv2-sys - Rust-lv2's C header bindings
Product: [Fedora] Fedora Reporter: Davide Cavalca <davide>
Component: Package ReviewAssignee: Neal Gompa <ngompa13>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: decathorpe, ngompa13, package-review
Target Milestone: ---Flags: ngompa13: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://crates.io/crates/lv2-sys
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-07-23 03:54:00 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2224751, 2224761, 2224762, 2224763, 2224764, 2224765, 2224767, 2224769, 2224770, 2224771    

Description Davide Cavalca 2023-07-22 16:52:38 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-lv2-sys/rust-lv2-sys.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-lv2-sys/rust-lv2-sys-2.0.0-1.fc39.src.rpm

Description:
Rust-lv2's C header bindings.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2023-07-22 16:52:41 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=103748570

Comment 2 Fedora Review Service 2023-07-22 16:59:11 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6203884
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2224759-rust-lv2-sys/fedora-rawhide-x86_64/06203884-rust-lv2-sys/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Neal Gompa 2023-07-22 21:38:18 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 4 Fedora Admin user for bugzilla script actions 2023-07-23 03:18:46 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-lv2-sys

Comment 5 Fedora Update System 2023-07-23 03:50:40 UTC
FEDORA-2023-66e76cdad4 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-66e76cdad4

Comment 6 Fedora Update System 2023-07-23 03:54:00 UTC
FEDORA-2023-66e76cdad4 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Fabio Valentini 2023-07-25 13:19:35 UTC
It's a bit unfortunate that this doesn't support regenerating bindings with bindgen - it would make supporting ppc64le and s390x easier than using the hard-coded bindings that are included in the crate.

Comment 8 Fedora Update System 2023-07-31 05:12:09 UTC
FEDORA-2023-3799773959 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-3799773959

Comment 9 Fedora Update System 2023-07-31 16:36:05 UTC
FEDORA-2023-844b251793 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-844b251793

Comment 10 Fedora Update System 2023-08-01 01:41:07 UTC
FEDORA-2023-3799773959 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-3799773959 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-3799773959

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2023-08-01 01:51:12 UTC
FEDORA-2023-844b251793 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-844b251793 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-844b251793

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2023-08-09 01:30:26 UTC
FEDORA-2023-3799773959 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2023-08-09 02:31:57 UTC
FEDORA-2023-844b251793 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.