Bug 2224783

Summary:	Review Request: dragonbox - Reference implementation of Dragonbox in C++
Product:	[Fedora] Fedora	Reporter:	Mattia Verga <mattia.verga>
Component:	Package Review	Assignee:	Felix Wang <topazus>
Status:	ASSIGNED ---	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, topazus
Target Milestone:	---	Flags:	topazus: fedora-review?
Target Release:	---
Hardware:	All
OS:	Linux
URL:	https://github.com/jk-jeon/dragonbox
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Mattia Verga 2023-07-22 18:47:17 UTC

Spec URL: https://mattia.fedorapeople.org/dragonbox/dragonbox.spec
SRPM URL: https://mattia.fedorapeople.org/dragonbox/dragonbox-1.1.3-1.fc39.src.rpm
Description: Dragonbox is a float-to-string conversion algorithm based on a beautiful algorithm Schubfach, developed by Raffaello Giulietti in 2017-2018. Dragonbox is further inspired by Grisu and Grisu-Exact.
Fedora Account System Username: mattia

Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=103754677

Comment 1 Fedora Review Service 2023-07-22 18:52:02 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6204266
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2224783-dragonbox/fedora-rawhide-x86_64/06204266-dragonbox/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Felix Wang 2023-07-25 07:06:34 UTC

Taking this.

Comment 3 Felix Wang 2023-07-25 07:39:52 UTC

I only see an issue: static library should be avoided as possible. The remaining things LGTM.

Comment 4 Mattia Verga 2023-08-02 12:35:53 UTC

(In reply to Felix Wang from comment #3)
> I only see an issue: static library should be avoided as possible. The
> remaining things LGTM.

This is a header only library, so adheres to https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static-libraries

BTW, if you're willing to make a formal review, you should set the ticket status to ASSIGNED and set yourself as the assignee.
Thanks.