Spec URL: https://mattia.fedorapeople.org/dragonbox/dragonbox.spec SRPM URL: https://mattia.fedorapeople.org/dragonbox/dragonbox-1.1.3-1.fc39.src.rpm Description: Dragonbox is a float-to-string conversion algorithm based on a beautiful algorithm Schubfach, developed by Raffaello Giulietti in 2017-2018. Dragonbox is further inspired by Grisu and Grisu-Exact. Fedora Account System Username: mattia Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=103754677
Copr build: https://copr.fedorainfracloud.org/coprs/build/6204266 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2224783-dragonbox/fedora-rawhide-x86_64/06204266-dragonbox/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Taking this.
I only see an issue: static library should be avoided as possible. The remaining things LGTM.
(In reply to Felix Wang from comment #3) > I only see an issue: static library should be avoided as possible. The > remaining things LGTM. This is a header only library, so adheres to https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static-libraries BTW, if you're willing to make a formal review, you should set the ticket status to ASSIGNED and set yourself as the assignee. Thanks.