Bug 2224956
| Summary: | Review Request: rust-alsa-sys - FFI bindings for the ALSA project (Advanced Linux Sound Architecture) | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Davide Cavalca <davide> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-07-25 06:36:19 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2224751, 2224957 | ||
|
Description
Davide Cavalca
2023-07-24 04:18:14 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=103810465 This package will need to be unretired: https://src.fedoraproject.org/rpms/rust-alsa-sys Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) === The package actually uses "pkgconfig(alsa)", so you might want to replace references to "alsa-lib-devel" with "pkgconfig(alsa)". Also, please add a rust2rpm.conf file to the package so they are automatically added by rust2rpm: ``` [DEFAULT] buildrequires = pkgconfig(alsa) lib.requires = pkgconfig(alsa) ``` Thanks! Filed the unretirement ticket: https://pagure.io/releng/issue/11563 FEDORA-2023-5777bbfefe has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-5777bbfefe FEDORA-2023-5777bbfefe has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2023-8f8b8e9a70 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-8f8b8e9a70 FEDORA-2023-e69645edce has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-e69645edce FEDORA-2023-e69645edce has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-e69645edce \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-e69645edce See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-8f8b8e9a70 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-8f8b8e9a70 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-8f8b8e9a70 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-8f8b8e9a70 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2023-e69645edce has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. |