Bug 2224956 - Review Request: rust-alsa-sys - FFI bindings for the ALSA project (Advanced Linux Sound Architecture)
Summary: Review Request: rust-alsa-sys - FFI bindings for the ALSA project (Advanced L...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2224751 2224957
TreeView+ depends on / blocked
 
Reported: 2023-07-24 04:18 UTC by Davide Cavalca
Modified: 2023-08-10 00:42 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-07-25 06:36:19 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2023-07-24 04:18:14 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-alsa-sys/rust-alsa-sys.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-alsa-sys/rust-alsa-sys-0.3.1-1.fc39.src.rpm

Description:
FFI bindings for the ALSA project (Advanced Linux Sound Architecture).

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2023-07-24 04:18:16 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=103810465

Comment 2 Davide Cavalca 2023-07-24 04:19:26 UTC
This package will need to be unretired: https://src.fedoraproject.org/rpms/rust-alsa-sys

Comment 3 Fabio Valentini 2023-07-24 12:40:49 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

The package actually uses "pkgconfig(alsa)", so you might want to replace references to "alsa-lib-devel" with "pkgconfig(alsa)".
Also, please add a rust2rpm.conf file to the package so they are automatically added by rust2rpm:

```
[DEFAULT]
buildrequires =
  pkgconfig(alsa)
lib.requires =
  pkgconfig(alsa)
```

Comment 4 Davide Cavalca 2023-07-24 15:13:56 UTC
Thanks! Filed the unretirement ticket: https://pagure.io/releng/issue/11563

Comment 5 Fedora Update System 2023-07-25 06:17:52 UTC
FEDORA-2023-5777bbfefe has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-5777bbfefe

Comment 6 Fedora Update System 2023-07-25 06:36:19 UTC
FEDORA-2023-5777bbfefe has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Fedora Update System 2023-08-01 04:57:00 UTC
FEDORA-2023-8f8b8e9a70 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-8f8b8e9a70

Comment 8 Fedora Update System 2023-08-01 05:09:05 UTC
FEDORA-2023-e69645edce has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-e69645edce

Comment 9 Fedora Update System 2023-08-02 01:37:53 UTC
FEDORA-2023-e69645edce has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-e69645edce \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-e69645edce

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2023-08-02 01:40:24 UTC
FEDORA-2023-8f8b8e9a70 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-8f8b8e9a70 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-8f8b8e9a70

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2023-08-10 00:40:42 UTC
FEDORA-2023-8f8b8e9a70 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2023-08-10 00:42:30 UTC
FEDORA-2023-e69645edce has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.