Bug 222611

Initial impressions (not going through the review guidelines yet)

It would be good to have your comment about the libdatrie "magic" next
to the Patch: line in the spec file, or maybe even better in the %build
section where the magic happens.

Requires: %{name} = %{PACKAGE_VERSION}

I prefer to write %{version}-%{release} there, but this should be fine too.

The devel package should require pkgconfig since it installs a pc file

I think we have a semi-standard variation of the summary/description for 
-devel packages. Something like "Header files necessary to develop applications
using libthai" or something to that end. Seems better than to use identical
text.

We don't package static libraries nowadays, unless there is a very good reason
for it.

Does it make any sense to put %{_docdir}/* in the file list ? normally packages
don't install docs there, it is where rpm puts the things that are marked as
%doc.

Trying to build in mock fails with:

gcc -shared  .libs/dummy.o -Wl,--whole-archive ../src/thctype/.libs/libthctype.a
../src/thstr/.libs/libthstr.a ../src/thcell/.libs/libthcell.a
../src/thinp/.libs/libthinp.a ../src/thrend/.libs/libthrend.a
../src/thcoll/.libs/libthcoll.a ../src/thbrk/.libs/libthbrk.a
../src/thwchar/.libs/libthwchar.a ../src/thwctype/.libs/libthwctype.a
../src/thwstr/.libs/libthwstr.a ../src/thwbrk/.libs/libthwbrk.a
-Wl,--no-whole-archive  -L/var/tmp/libthai-0.1.7-root-mockbuild/usr/lib
-L/usr/lib -ldatrie  -Wl,-soname -Wl,libthai.so.0 -o .libs/libthai.so.0.1.1
/usr/bin/ld: cannot find -ldatrie

Created attachment 145715 [details]
full mock build log

Uploaded updated spec file and libthai-0.1.7-2.fc7.src.rpm fixing all issues above.

to make this build in mock with automake 1.10, I had to first
add aclocal calls before the automake calls, and then add a
BuildRequires: libtool

With these changes, the rpm builds fine, and rpmlint has no complaints
about the resulting base rpm, but for the -devel, it says:

W: libthai-devel incoherent-version-dependency-on libthai libthai-0.1.7 0.1.7
E: libthai-devel standard-dir-owned-by-package /usr/share/man/man3

Trying to install the -devel package fails with

error: Failed dependencies:
        libthai = libthai-0.1.7 is needed by libthai-devel-0.1.7-2.fc7.i386

after installing the base rpm.


One thing I wondered about is the format of the files that are installed in
/usr/share/libthai. They look binary, are they arch-independent ?

Created attachment 145765 [details]
spec file 

the attached spec contains the fixes I needed to get libthai and libthai-devel
to build and install without rpmlint warnings.

Ok, doing the review based upon the spec file attached in the previous comment.

+ rpmlint is silent
+ package name follows naming conventions
+ spec file name matches package name
+ package follows packaging guidelines
+ license is LGPL
- spec license tag says GPL --> THIS NEEDS FIXING
+ COPYING is in %doc
+ spec is in English (haven't checked carefully if it is 
  American or Canadian English...)
+ spec is legible and contains comments
+ md5sums of sources match upstream
+ packages built fine in mock on i386
+ complete BuildRequires listed
+ no locale data to handle
+ calls ldconfig in %post/%postun
+ no Prefix:
+ owns all non-standard directories
+ no dupes in file lists
+ file lists have %defattr
+ %clean is present
+ uses macros for standard paths
+ package contains code
+ no doc subpackage necessary
+ %doc has only docs
+ -devel package is there and contains the right stuff
+ -devel requires pkgconfig
+ libraries are correctly packaged
+ -devel requires base package
+ .la files are stripped
+ no desktop file necessary
+ package owns no directories owned by others

btw, Behdad answered my question regarding the binary files in /usr/share: The
are arch-independent.

Accepting the package with the provision that the License: tag is corrected for
the initial build.

Package added to brew.  Close this bug once built for rawhide.

Built last week or so.