Bug 2226663
| Summary: | Review Request: shell-color-prompt - Color prompt for bash shell | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jens Petersen <petersen> |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | awilliam, ngompa13, package-review |
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://copr.fedorainfracloud.org/coprs/petersen/bash-color-prompt | ||
| Whiteboard: | |||
| Fixed In Version: | shell-color-prompt-0.1-6.fc39 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-08-30 01:35:23 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2233267 | ||
|
Description
Jens Petersen
2023-07-26 06:46:46 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/6213259 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2226663-bash-color-prompt/fedora-rawhide-x86_64/06213259-bash-color-prompt/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Taking this package. Could we rename this source package to shell-color-prompt and provide a subpackage bash-color-prompt? That way if we want to provide equivalent definitions for other packaged shells, they can be provided in this source package. Good idea - that seems reason. Also I forgot to link to the Change proposal here: https://fedoraproject.org/wiki/Changes/Color_Bash_Prompt Spec URL: https://petersen.fedorapeople.org/reviews/shell-color-prompt/shell-color-prompt.spec SRPM URL: https://petersen.fedorapeople.org/reviews/shell-color-prompt/shell-color-prompt-0.1-6.fc40.src.rpm rename source package to shell-color-prompt Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=104858150 Copr build: https://copr.fedorainfracloud.org/coprs/build/6276571 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2226663-shell-color-prompt/fedora-rawhide-x86_64/06276571-shell-color-prompt/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Review notes: * Package follows packaging guidelines * Package builds and installs * Package licensing is correct and license files are installed properly * No serious issues from rpmlint PACKAGE APPROVED. The Pagure repository was created at https://src.fedoraproject.org/rpms/shell-color-prompt Thank you for the review, Neal! https://pagure.io/releng/fedora-scm-requests/issue/55732 https://pagure.io/releng/fedora-scm-requests/issue/55733 FEDORA-2023-c208b6591d has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-c208b6591d FEDORA-2023-c208b6591d has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-c208b6591d \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-c208b6591d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-c208b6591d has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. |