Bug 2226663

Summary: Review Request: shell-color-prompt - Color prompt for bash shell
Product: [Fedora] Fedora Reporter: Jens Petersen <petersen>
Component: Package ReviewAssignee: Neal Gompa <ngompa13>
Status: ASSIGNED --- QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: ngompa13, package-review
Target Milestone: ---Flags: ngompa13: fedora-review?
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://copr.fedorainfracloud.org/coprs/petersen/bash-color-prompt
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Comment 1 Fedora Review Service 2023-07-26 06:53:28 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6213259
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2226663-bash-color-prompt/fedora-rawhide-x86_64/06213259-bash-color-prompt/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Neal Gompa 2023-07-26 13:04:33 UTC
Taking this package.

Comment 3 Neal Gompa 2023-08-10 20:55:08 UTC
Could we rename this source package to shell-color-prompt and provide a subpackage bash-color-prompt? That way if we want to provide equivalent definitions for other packaged shells, they can be provided in this source package.

Comment 4 Jens Petersen 2023-08-15 01:43:18 UTC
Good idea - that seems reason.

Also I forgot to link to the Change proposal here:
https://fedoraproject.org/wiki/Changes/Color_Bash_Prompt

Comment 6 Fedora Review Service 2023-08-15 02:17:13 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6276571
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2226663-shell-color-prompt/fedora-rawhide-x86_64/06276571-shell-color-prompt/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.