Bug 2226663 - Review Request: shell-color-prompt - Color prompt for bash shell
Summary: Review Request: shell-color-prompt - Color prompt for bash shell
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL: https://copr.fedorainfracloud.org/cop...
Whiteboard:
Depends On:
Blocks: 2233267
TreeView+ depends on / blocked
 
Reported: 2023-07-26 06:46 UTC by Jens Petersen
Modified: 2023-08-30 01:35 UTC (History)
3 users (show)

Fixed In Version: shell-color-prompt-0.1-6.fc39
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-08-30 01:35:23 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Comment 1 Fedora Review Service 2023-07-26 06:53:28 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6213259
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2226663-bash-color-prompt/fedora-rawhide-x86_64/06213259-bash-color-prompt/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Neal Gompa 2023-07-26 13:04:33 UTC
Taking this package.

Comment 3 Neal Gompa 2023-08-10 20:55:08 UTC
Could we rename this source package to shell-color-prompt and provide a subpackage bash-color-prompt? That way if we want to provide equivalent definitions for other packaged shells, they can be provided in this source package.

Comment 4 Jens Petersen 2023-08-15 01:43:18 UTC
Good idea - that seems reason.

Also I forgot to link to the Change proposal here:
https://fedoraproject.org/wiki/Changes/Color_Bash_Prompt

Comment 6 Fedora Review Service 2023-08-15 02:17:13 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6276571
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2226663-shell-color-prompt/fedora-rawhide-x86_64/06276571-shell-color-prompt/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Neal Gompa 2023-08-21 15:38:13 UTC
Review notes:

* Package follows packaging guidelines
* Package builds and installs
* Package licensing is correct and license files are installed properly
* No serious issues from rpmlint

PACKAGE APPROVED.

Comment 8 Fedora Admin user for bugzilla script actions 2023-08-21 15:40:05 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/shell-color-prompt

Comment 9 Jens Petersen 2023-08-21 15:40:37 UTC
Thank you for the review, Neal!

Comment 11 Fedora Update System 2023-08-21 16:33:39 UTC
FEDORA-2023-c208b6591d has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-c208b6591d

Comment 12 Fedora Update System 2023-08-22 01:15:59 UTC
FEDORA-2023-c208b6591d has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-c208b6591d \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-c208b6591d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2023-08-30 01:35:23 UTC
FEDORA-2023-c208b6591d has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.