Bug 2226663 - Review Request: shell-color-prompt - Color prompt for bash shell
Summary: Review Request: shell-color-prompt - Color prompt for bash shell
Keywords:
Status: ASSIGNED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL: https://copr.fedorainfracloud.org/cop...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-07-26 06:46 UTC by Jens Petersen
Modified: 2023-08-15 02:17 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
ngompa13: fedora-review?


Attachments (Terms of Use)

Comment 1 Fedora Review Service 2023-07-26 06:53:28 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6213259
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2226663-bash-color-prompt/fedora-rawhide-x86_64/06213259-bash-color-prompt/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Neal Gompa 2023-07-26 13:04:33 UTC
Taking this package.

Comment 3 Neal Gompa 2023-08-10 20:55:08 UTC
Could we rename this source package to shell-color-prompt and provide a subpackage bash-color-prompt? That way if we want to provide equivalent definitions for other packaged shells, they can be provided in this source package.

Comment 4 Jens Petersen 2023-08-15 01:43:18 UTC
Good idea - that seems reason.

Also I forgot to link to the Change proposal here:
https://fedoraproject.org/wiki/Changes/Color_Bash_Prompt

Comment 6 Fedora Review Service 2023-08-15 02:17:13 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6276571
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2226663-shell-color-prompt/fedora-rawhide-x86_64/06276571-shell-color-prompt/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


Note You need to log in before you can comment on or make changes to this bug.