Bug 2226668

Summary: Review Request: gismo - A C++ library for isogeometric analysis (IGA)
Product: [Fedora] Fedora Reporter: Felix Wang <topazus>
Component: Package ReviewAssignee: Phil Wyett <philip.wyett>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: benson_muite, package-review, philip.wyett
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---   
Hardware: All   
OS: Linux   
URL: https://github.com/gismo/gismo
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2026-04-21 00:45:25 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 201449    
Attachments:
Description Flags
The .spec file difference from Copr build 6646434 to 6646435
none
The .spec file difference from Copr build 6646435 to 10225643
none
The .spec file difference from Copr build 10225643 to 10226620 none

Description Felix Wang 2023-07-26 07:38:55 UTC 
Spec URL: https://topazus.fedorapeople.org/rpms/gismo.spec
SRPM URL: https://topazus.fedorapeople.org/rpms/gismo-21.12.0-1.20230630gitf3e05c3.fc39.src.rpm
Description:
G+Smo (Geometry + Simulation Modules, pronounced "gismo") is an open-source C++
library that brings together mathematical tools for geometric design and
numerical simulation. It implements the relatively new paradigm of isogeometric
analysis, which suggests the use of a unified framework in the design and
analysis pipeline. G+Smo is an object-oriented, cross-platform, template C++
library and follows the generic programming principle, with a focus on both
efficiency and ease of use. The library aims at providing access to high
quality, open-source software to the forming isogeometric numerical simulation
community and beyond.

Fedora Account System Username: topazus
Comment 1 Felix Wang 2023-11-16 00:48:25 UTC 
[fedora-review-service-build]
Comment 2 Fedora Review Service 2023-11-16 01:15:18 UTC 
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6645833
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2226668-gismo/fedora-rawhide-x86_64/06645833-gismo/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
Comment 3 Felix Wang 2023-11-16 05:43:37 UTC 
Spec URL: https://topazus.fedorapeople.org/rpms/gismo.spec
SRPM URL: https://topazus.fedorapeople.org/rpms/gismo-21.12.0-1.20230630gitf3e05c3.fc39.src.rpm
Comment 4 Felix Wang 2023-11-16 05:44:35 UTC 
update to 23.09.

Spec URL: https://topazus.fedorapeople.org/rpms/gismo.spec
SRPM URL: https://topazus.fedorapeople.org/rpms/gismo-23.09.0-1.fc40.src.rpm
Comment 5 Fedora Review Service 2023-11-16 06:09:59 UTC 
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6646434
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2226668-gismo/fedora-rawhide-x86_64/06646434-gismo/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
Comment 6 Fedora Review Service 2023-11-16 06:26:25 UTC 
Created attachment 1999708 [details]
The .spec file difference from Copr build 6646434 to 6646435
Comment 7 Fedora Review Service 2023-11-16 06:26:28 UTC 
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6646435
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2226668-gismo/fedora-rawhide-x86_64/06646435-gismo/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
Comment 8 Benson Muite 2023-11-16 08:19:24 UTC 
Initial comments:
a) Can tests be run?
b) Should additional functionality be enabled, for example, Eigen, MPI, UMFPACK, TAUCS, SUPERLU?
Comment 9 Benson Muite 2023-11-18 18:59:50 UTC 
c) Warning when running fedora-review:

[!]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
     Note: Arch-ed rpms have a total of 43612160 bytes in /usr/share gismo-
     examples-23.09.0-1.fc40.aarch64.rpm:43591680
     See:
     https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines
Probably want to make a noarch package examples-data which would then be required by
the examples package.
Comment 10 Package Review 2024-11-18 00:45:23 UTC 
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems
that the review is still being working out by you. If this is right, please
respond to this comment clearing the NEEDINFO flag and try to reach out the
submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the
fedora-review flag and reset the assignee, so that a new reviewer can take
this ticket.

Without any reply, this request will shortly be resetted.
Comment 11 Benson Muite 2024-11-19 09:18:34 UTC 
Happy to finish review.
Comment 12 Package Review 2025-11-20 00:45:23 UTC 
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems
that the review is still being working out by you. If this is right, please
respond to this comment clearing the NEEDINFO flag and try to reach out the
submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the
fedora-review flag and reset the assignee, so that a new reviewer can take
this ticket.

Without any reply, this request will shortly be resetted.
Comment 13 Benson Muite 2025-11-20 17:08:48 UTC 
resetting assignee.
Comment 14 Phil Wyett 2026-03-10 08:49:23 UTC 
Hi,

Before we go any further. Do you still have an appetite for getting this package into Fedora?

Can you do a fresh upload of spec and srpm files for further testing. Be sure to take into account previous comments.

Regards

Phil
Comment 15 Felix Wang 2026-03-14 14:00:47 UTC 
1) enabled tests.
2) built against MPI, UMFPACK, SUPERLU.
3) put files in /usr/share in -data subpackage.

Spec URL: https://topazus.fedorapeople.org/gismo.spec
SRPM URL: https://topazus.fedorapeople.org/gismo-25.07.0-1.fc44.src.rpm
Comment 16 Fedora Review Service 2026-03-14 15:29:06 UTC 
Created attachment 2133402 [details]
The .spec file difference from Copr build 6646435 to 10225643
Comment 17 Fedora Review Service 2026-03-14 15:29:08 UTC 
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10225643
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2226668-gismo/fedora-rawhide-x86_64/10225643-gismo/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
Comment 18 Phil Wyett 2026-03-14 20:50:09 UTC 
Hi,

Are we sure linking to a Pull Request (PR) that can be modified and appear differently if
the PR is edited. I would prefer this patch be local in the sources. Is there prior use of
this method that I am unaware of?

Due to my time constraints, I will be reviewing this package in small bites.

Regards

Phil
Comment 19 Felix Wang 2026-03-15 01:38:34 UTC 
Thanks for your reviewing this. I switched to use local patch file.

Spec URL: https://topazus.fedorapeople.org/gismo.spec
SRPM URL: https://topazus.fedorapeople.org/gismo-25.07.0-1.fc44.src.rpm
Comment 20 Fedora Review Service 2026-03-15 03:09:21 UTC 
Created attachment 2133478 [details]
The .spec file difference from Copr build 10225643 to 10226620
Comment 21 Fedora Review Service 2026-03-15 03:09:24 UTC 
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10226620
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2226668-gismo/fedora-rawhide-x86_64/10226620-gismo/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
Comment 22 Phil Wyett 2026-03-21 09:05:32 UTC 
Hi,

It's the weekend, sorry, but work took over for the last few days.

Could you work through package installs, singular and combinations as dependency issues exists.

Please also review RPM lint issues, from current build below.

============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpprprcka9')]
checks: 32, packages: 11

gismo-devel.x86_64: E: zero-length /usr/include/gismo/gsCore/gsConfigExt.h
gismo.src: E: spelling-error ('isogeometric', 'Summary(en_US) isogeometric -> isometrics, isometric, geometric')
gismo.src: E: spelling-error ('isogeometric', '%description -l en_US isogeometric -> isometrics, isometric, geometric')
gismo.x86_64: E: spelling-error ('isogeometric', 'Summary(en_US) isogeometric -> isometrics, isometric, geometric')
gismo.x86_64: E: spelling-error ('isogeometric', '%description -l en_US isogeometric -> isometrics, isometric, geometric')
gismo-mpich-devel.x86_64: W: only-non-binary-in-usr-lib
gismo-openmpi-devel.x86_64: W: only-non-binary-in-usr-lib
gismo-examples.x86_64: W: no-manual-page-for-binary L2projection_example
gismo-examples.x86_64: W: no-manual-page-for-binary adaptRefinementThb_example
gismo-examples.x86_64: W: no-manual-page-for-binary adaptiveConvectionDiffusionReaction_example
gismo-examples.x86_64: W: no-manual-page-for-binary as_parameterization_example
gismo-examples.x86_64: W: no-manual-page-for-binary assembly_example
gismo-examples.x86_64: W: no-manual-page-for-binary bSplineBasis_example
gismo-examples.x86_64: W: no-manual-page-for-binary bSplineCurve_example
gismo-examples.x86_64: W: no-manual-page-for-binary bSplineSurface_example
gismo-examples.x86_64: W: no-manual-page-for-binary basis_example
gismo-examples.x86_64: W: no-manual-page-for-binary biharmonic2_example
gismo-examples.x86_64: W: no-manual-page-for-binary biharmonic_example
gismo-examples.x86_64: W: no-manual-page-for-binary commandLineArg_example
gismo-examples.x86_64: W: no-manual-page-for-binary compositions_example
gismo-examples.x86_64: W: no-manual-page-for-binary constrained_fitting
gismo-examples.x86_64: W: no-manual-page-for-binary domains_example
gismo-examples.x86_64: W: no-manual-page-for-binary fileIo_example
gismo-examples.x86_64: W: no-manual-page-for-binary fitting_example
gismo-examples.x86_64: W: no-manual-page-for-binary fitting_mspline
gismo-examples.x86_64: W: no-manual-page-for-binary geometry_example
gismo-examples.x86_64: W: no-manual-page-for-binary gsAdaptiveMeshing_example
gismo-examples.x86_64: W: no-manual-page-for-binary gsHBox_example
gismo-examples.x86_64: W: no-manual-page-for-binary gsInterpolateMap
gismo-examples.x86_64: W: no-manual-page-for-binary gsMakeMultiPatch
gismo-examples.x86_64: W: no-manual-page-for-binary gsMappedSpline_example
gismo-examples.x86_64: W: no-manual-page-for-binary gsPatchFromBoundary
gismo-examples.x86_64: W: no-manual-page-for-binary gsView
gismo-examples.x86_64: W: no-manual-page-for-binary heatEquation_example
gismo-examples.x86_64: W: no-manual-page-for-binary ieti2_example
gismo-examples.x86_64: W: no-manual-page-for-binary ieti_example
gismo-examples.x86_64: W: no-manual-page-for-binary inputOutput_example
gismo-examples.x86_64: W: no-manual-page-for-binary kirchhoff-Love_example
gismo-examples.x86_64: W: no-manual-page-for-binary knotVector_example
gismo-examples.x86_64: W: no-manual-page-for-binary linearAlgebra_example
gismo-examples.x86_64: W: no-manual-page-for-binary linearSolvers_example
gismo-examples.x86_64: W: no-manual-page-for-binary linear_elasticity_example
gismo-examples.x86_64: W: no-manual-page-for-binary mpi_example
gismo-examples.x86_64: W: no-manual-page-for-binary multiGrid_example
gismo-examples.x86_64: W: no-manual-page-for-binary nonlinear_example
gismo-examples.x86_64: W: no-manual-page-for-binary optimizer_example
gismo-examples.x86_64: W: no-manual-page-for-binary pMultiGrid_example
gismo-examples.x86_64: W: no-manual-page-for-binary parametrization_example
gismo-examples.x86_64: W: no-manual-page-for-binary paraview_example
gismo-examples.x86_64: W: no-manual-page-for-binary patches_from_mesh
gismo-examples.x86_64: W: no-manual-page-for-binary poisson2_example
gismo-examples.x86_64: W: no-manual-page-for-binary poissonTHB_example
gismo-examples.x86_64: W: no-manual-page-for-binary precision_example
gismo-examples.x86_64: W: no-manual-page-for-binary quadrature_example
gismo-examples.x86_64: W: no-manual-page-for-binary quasiInterpolation_example
gismo-examples.x86_64: W: no-manual-page-for-binary refitting_example
gismo-examples.x86_64: W: no-manual-page-for-binary sparseSolvers_example
gismo-examples.x86_64: W: no-manual-page-for-binary stokes_ieti_example
gismo-examples.x86_64: W: no-manual-page-for-binary surfaceReparametrization_example
gismo-examples.x86_64: W: no-manual-page-for-binary thbRefinement_example
gismo-examples.x86_64: W: no-manual-page-for-binary thbSplineBasis_example
gismo-examples.x86_64: W: no-manual-page-for-binary triangulatedMeshToSolid_example
gismo-examples.x86_64: W: no-manual-page-for-binary trilinos_example
gismo-data.noarch: W: no-documentation
gismo-devel.x86_64: W: no-documentation
gismo-examples.x86_64: W: no-documentation
gismo-mpich-devel.x86_64: W: no-documentation
gismo-mpich-examples.x86_64: W: no-documentation
gismo-openmpi-devel.x86_64: W: no-documentation
gismo-openmpi-examples.x86_64: W: no-documentation
gismo-devel.x86_64: E: double-slash-in-pkgconfig-path /usr/lib64/pkgconfig/gismo.pc libdir=${prefix}//usr/lib64
gismo-devel.x86_64: E: double-slash-in-pkgconfig-path /usr/lib64/pkgconfig/gismo.pc includedir=${prefix}//usr/include
gismo-mpich-devel.x86_64: E: double-slash-in-pkgconfig-path /usr/lib64/mpich/lib/pkgconfig/gismo.pc libdir=${prefix}//usr/lib64/mpich/lib
gismo-mpich-devel.x86_64: E: double-slash-in-pkgconfig-path /usr/lib64/mpich/lib/pkgconfig/gismo.pc includedir=${prefix}//usr/include/mpich-x86_64
gismo-openmpi-devel.x86_64: E: double-slash-in-pkgconfig-path /usr/lib64/openmpi/lib/pkgconfig/gismo.pc libdir=${prefix}//usr/lib64/openmpi/lib
gismo-openmpi-devel.x86_64: E: double-slash-in-pkgconfig-path /usr/lib64/openmpi/lib/pkgconfig/gismo.pc includedir=${prefix}//usr/include/openmpi-x86_64
 11 packages and 0 specfiles checked; 11 errors, 65 warnings, 92 filtered, 11 badness; has taken 8.4 s 

Regards

Phil
Comment 23 Package Review 2026-04-21 00:45:25 UTC 
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.