Bug 2226668
| Summary: | Review Request: gismo - A C++ library for isogeometric analysis (IGA) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Felix Wang <topazus> | ||||
| Component: | Package Review | Assignee: | Benson Muite <benson_muite> | ||||
| Status: | ASSIGNED --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | benson_muite, package-review | ||||
| Target Milestone: | --- | Flags: | benson_muite:
fedora-review?
|
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | Type: | --- | |||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Felix Wang
2023-07-26 07:38:55 UTC
[fedora-review-service-build] Copr build: https://copr.fedorainfracloud.org/coprs/build/6645833 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2226668-gismo/fedora-rawhide-x86_64/06645833-gismo/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://topazus.fedorapeople.org/rpms/gismo.spec SRPM URL: https://topazus.fedorapeople.org/rpms/gismo-21.12.0-1.20230630gitf3e05c3.fc39.src.rpm update to 23.09. Spec URL: https://topazus.fedorapeople.org/rpms/gismo.spec SRPM URL: https://topazus.fedorapeople.org/rpms/gismo-23.09.0-1.fc40.src.rpm Copr build: https://copr.fedorainfracloud.org/coprs/build/6646434 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2226668-gismo/fedora-rawhide-x86_64/06646434-gismo/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Created attachment 1999708 [details]
The .spec file difference from Copr build 6646434 to 6646435
Copr build: https://copr.fedorainfracloud.org/coprs/build/6646435 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2226668-gismo/fedora-rawhide-x86_64/06646435-gismo/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Initial comments: a) Can tests be run? b) Should additional functionality be enabled, for example, Eigen, MPI, UMFPACK, TAUCS, SUPERLU? c) Warning when running fedora-review:
[!]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
Note: Arch-ed rpms have a total of 43612160 bytes in /usr/share gismo-
examples-23.09.0-1.fc40.aarch64.rpm:43591680
See:
https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines
Probably want to make a noarch package examples-data which would then be required by
the examples package.
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time, but it seems that the review is still being working out by you. If this is right, please respond to this comment clearing the NEEDINFO flag and try to reach out the submitter to proceed with the review. If you're not interested in reviewing this ticket anymore, please clear the fedora-review flag and reset the assignee, so that a new reviewer can take this ticket. Without any reply, this request will shortly be resetted. Happy to finish review. |