Bug 2226668 - Review Request: gismo - A C++ library for isogeometric analysis (IGA)
Summary: Review Request: gismo - A C++ library for isogeometric analysis (IGA)
Keywords:
Status: ASSIGNED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Benson Muite
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-07-26 07:38 UTC by Felix Wang
Modified: 2023-11-18 18:59 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
benson_muite: fedora-review?


Attachments (Terms of Use)
The .spec file difference from Copr build 6646434 to 6646435 (2.09 KB, patch)
2023-11-16 06:26 UTC, Fedora Review Service
no flags Details | Diff

Description Felix Wang 2023-07-26 07:38:55 UTC
Spec URL: https://topazus.fedorapeople.org/rpms/gismo.spec
SRPM URL: https://topazus.fedorapeople.org/rpms/gismo-21.12.0-1.20230630gitf3e05c3.fc39.src.rpm
Description:
G+Smo (Geometry + Simulation Modules, pronounced "gismo") is an open-source C++
library that brings together mathematical tools for geometric design and
numerical simulation. It implements the relatively new paradigm of isogeometric
analysis, which suggests the use of a unified framework in the design and
analysis pipeline. G+Smo is an object-oriented, cross-platform, template C++
library and follows the generic programming principle, with a focus on both
efficiency and ease of use. The library aims at providing access to high
quality, open-source software to the forming isogeometric numerical simulation
community and beyond.

Fedora Account System Username: topazus

Comment 1 Felix Wang 2023-11-16 00:48:25 UTC
[fedora-review-service-build]

Comment 2 Fedora Review Service 2023-11-16 01:15:18 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6645833
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2226668-gismo/fedora-rawhide-x86_64/06645833-gismo/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Fedora Review Service 2023-11-16 06:09:59 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6646434
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2226668-gismo/fedora-rawhide-x86_64/06646434-gismo/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Fedora Review Service 2023-11-16 06:26:25 UTC
Created attachment 1999708 [details]
The .spec file difference from Copr build 6646434 to 6646435

Comment 7 Fedora Review Service 2023-11-16 06:26:28 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6646435
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2226668-gismo/fedora-rawhide-x86_64/06646435-gismo/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 8 Benson Muite 2023-11-16 08:19:24 UTC
Initial comments:
a) Can tests be run?
b) Should additional functionality be enabled, for example, Eigen, MPI, UMFPACK, TAUCS, SUPERLU?

Comment 9 Benson Muite 2023-11-18 18:59:50 UTC
c) Warning when running fedora-review:

[!]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
     Note: Arch-ed rpms have a total of 43612160 bytes in /usr/share gismo-
     examples-23.09.0-1.fc40.aarch64.rpm:43591680
     See:
     https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines
Probably want to make a noarch package examples-data which would then be required by
the examples package.


Note You need to log in before you can comment on or make changes to this bug.