Bug 2226714

Summary: Using ERB with "Test Webhook" functionality raises an exception
Product: Red Hat Satellite Reporter: Lukáš Hellebrandt <lhellebr>
Component: Hooks and WebhooksAssignee: Oleh Fedorenko <ofedoren>
Status: CLOSED ERRATA QA Contact: Peter Ondrejka <pondrejk>
Severity: low Docs Contact:
Priority: unspecified    
Version: 6.14.0CC: ahumbe, aruzicka, rlavi
Target Milestone: 6.15.0Keywords: Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-04-23 17:11:56 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Lukáš Hellebrandt 2023-07-26 09:38:57 UTC
Description of problem:
When I use ERB in the webhook's Target URL, the testing the webhook throws an exception. E.g. using "http://machine.example.com/inventory/<%= @object.id %>", a test throws:
"""
Error
Webhook test failed: undefined method '#id' for NilClass::Jail (NilClass)
"""

When testing a webhook, the following is shown to the user:
"""
You are about to test test webhook. Please, note that this will not contain actual information or render the attached template. You can specify below a custom payload to test the webhook with.
"""

It states that the request's content won't contain the actual info. But this is in target URL. It's understandable why it doesn't work because while testing, there is actually no object to populate that variable with. But it may be unexpected by the user.

Version-Release number of selected component (if applicable):
Sat 6.14.0, previous versions didn't have Test Webhook functionality

How reproducible:
Deterministic

Steps to Reproduce:
1. Administer -> Webhooks -> Create
2. Fill in, use a variable in the target URL, e.g. "http://machine.example.com/inventory/<%= @object.id %>"
3. Submit, Test Webhook

Actual results:
The variable can't be used

Expected results:
The variable can be used or the failure is more expectable by the user, it shouldn't look like a bug

Comment 2 Lukáš Hellebrandt 2023-07-27 14:54:05 UTC
Version-Release number of selected component (if applicable):
Sat 6.14.0, previous versions didn't have Test Webhook functionality

Comment 3 Brad Buckingham 2023-10-30 11:29:29 UTC
Bulk setting Target Milestone = 6.15.0 where sat-6.15.0+ is set.

Comment 4 Peter Ondrejka 2023-11-27 15:24:38 UTC
Verified in Satellite stream snap 38

Comment 7 errata-xmlrpc 2024-04-23 17:11:56 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Satellite 6.15.0 release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2024:2010