Bug 2226714 - Using ERB with "Test Webhook" functionality raises an exception
Summary: Using ERB with "Test Webhook" functionality raises an exception
Keywords:
Status: NEW
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: Hooks and Webhooks
Version: 6.14.0
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: Unspecified
Assignee: satellite6-bugs
QA Contact: Satellite QE Team
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-07-26 09:38 UTC by Lukáš Hellebrandt
Modified: 2023-08-10 07:46 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker SAT-19261 0 None None None 2023-07-31 12:21:37 UTC

Description Lukáš Hellebrandt 2023-07-26 09:38:57 UTC
Description of problem:
When I use ERB in the webhook's Target URL, the testing the webhook throws an exception. E.g. using "http://machine.example.com/inventory/<%= @object.id %>", a test throws:
"""
Error
Webhook test failed: undefined method '#id' for NilClass::Jail (NilClass)
"""

When testing a webhook, the following is shown to the user:
"""
You are about to test test webhook. Please, note that this will not contain actual information or render the attached template. You can specify below a custom payload to test the webhook with.
"""

It states that the request's content won't contain the actual info. But this is in target URL. It's understandable why it doesn't work because while testing, there is actually no object to populate that variable with. But it may be unexpected by the user.

Version-Release number of selected component (if applicable):
Sat 6.14.0, previous versions didn't have Test Webhook functionality

How reproducible:
Deterministic

Steps to Reproduce:
1. Administer -> Webhooks -> Create
2. Fill in, use a variable in the target URL, e.g. "http://machine.example.com/inventory/<%= @object.id %>"
3. Submit, Test Webhook

Actual results:
The variable can't be used

Expected results:
The variable can be used or the failure is more expectable by the user, it shouldn't look like a bug

Comment 2 Lukáš Hellebrandt 2023-07-27 14:54:05 UTC
Version-Release number of selected component (if applicable):
Sat 6.14.0, previous versions didn't have Test Webhook functionality


Note You need to log in before you can comment on or make changes to this bug.