Bug 2227475

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=104118329

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6223017
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2227475-rust-librsvg/fedora-rawhide-x86_64/06223017-rust-librsvg/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Don't do this:

> %global __cargo_is_bin() false

The %__cargo_is_bin macro is an internal implementation detail (hence the __ prefix), which can change or be removed at any time (in fact, it *did* change in rust-packaging >= 24). Setting it to false / 0 is an incomplete and hacky way to disable binaries that doesn't correctly affect spec file generation.

Instead, patch Cargo.toml to remove binaries:

- remove all [[bin]] sections (if present)
- add "autobins = false" to the [package] table (if necessary)

This way rust2rpm will correctly detect that the package has no binaries and will write a library-only spec file accordingly.

===

You also don't need to manually list all the skipped tests if they share a common prefix, the "--skip" flag does substring matching unless the "--exact" flag is passed to the test harness as well.

If you indeed want to avoid matching on tests that you *don't* want to skip, then add the "--exact" flag. If you don't mind skipping some more tests than necessary, you could simplify the %cargo_test call by using the substring matching.

===

Note that if you want to package this crate for older Fedora releases as well, you will likely need separate branches / patches, since some dependencies that are only used by librsvg2 currently are at different versions in different branches (f38: lopdf 0.29, f37: lopdf 0.27).

I have started providing the same versions of libraries across all Fedora branches to avoid situations like these, but since lopdf is currently only a dependency of librsvg2, it didn't make sense to maintain multiple versions of it.

Spec URL: https://dcavalca.fedorapeople.org/review/rust-librsvg/rust-librsvg.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-librsvg/rust-librsvg-2.56.0-1.fc39.src.rpm

Changelog:
- patch metadata to disable binaries
- use substring matching for tests

Created attachment 1980747 [details]
The .spec file difference from Copr build 6223017 to 6223682

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6223682
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2227475-rust-librsvg/fedora-rawhide-x86_64/06223682-rust-librsvg/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Thanks, looks good to me now (with one exception, noted below).
This package is even running tests, which the librsvg2 package apparently doesn't 😅

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (LGPL-2.1-or-later) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

This crate tarball contains a large amount of stuff that's unused and should be dropped.
For example, there's a lot of data files (graphics and fonts with separate licenses, etc.) that should be excluded since autotools, docs, CI files, etc. are all unwanted in a pure-Rust library package.

Adding something like this to the [package] table in Cargo.toml should work
(with "%doc %{crate_instdir}/rsvg-convert.rst" removed from the file list):

"""
exclude = [
    "/benchmarks/",
    "/ci/",
    "/devel-docs/",
    "/doc/",
    "/include",
    "/m4/",
    "/tests/",
    "/tools/",
    "/win32",
    "/acinclude.m4",
    "/appveyor.yml",
    "/autogen.sh",
    "/configure.ac",
    "/deny.toml",
    "/example.svg",
    "/glib-tap.mk",
    "/INSTALL",
    "/librsvg.doap",
    "/librsvg.pc.in",
    "/librsvg-zip.in",
    "/Makefile.am",
    "/Rsvg-2.0.metadata",
    "/Rsvg-2.0-custom.vala",
    "/rsvg-convert.rst",
    "/rsvg-c-srcs.mk",
    "/tap-driver.sh",
    "/tap-test",
]
"""

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-librsvg

FEDORA-2023-bb211d2f48 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-bb211d2f48

FEDORA-2023-bb211d2f48 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2023-c2d333f341 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-c2d333f341

FEDORA-2023-c2d333f341 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.