Bug 2224817 - package librsvg rust crate
Summary: package librsvg rust crate
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: librsvg2
Version: rawhide
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Matthias Clasen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2227475
Blocks: 2224807
TreeView+ depends on / blocked
 
Reported: 2023-07-23 05:23 UTC by Davide Cavalca
Modified: 2023-08-07 01:26 UTC (History)
7 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-07-31 08:29:43 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Davide Cavalca 2023-07-23 05:23:57 UTC
librsvg provides a rust crate (https://crates.io/crates/librsvg) which is needed to package tiny-dfr, but doesn't seem to be currently included in the librsvg2 package in Fedora.

Reproducible: Always

Comment 1 Davide Cavalca 2023-07-23 14:53:41 UTC
On further investigation, this might have to wait on https://gitlab.gnome.org/GNOME/librsvg/-/issues/995

Comment 2 Kalev Lember 2023-07-24 15:17:02 UTC
I think it would be easiest for now to package rust-librsvg separately, until we figure out how to build both the C library and the rsvg pixbuf loader and the rust crate from the same source package. It might be worth to eventually move everything over to rust-librsvg source package, but I think it would be easiest to just have two separate packages for now to unblock tiny-dfr. I'm happy to maintain both and ensure they both get updated.

Comment 3 Davide Cavalca 2023-07-24 15:27:44 UTC
That works for me, thanks Kalev!

Comment 4 Davide Cavalca 2023-07-30 01:38:54 UTC
Put rust-librsvg up at https://bugzilla.redhat.com/show_bug.cgi?id=2227475

Comment 5 Davide Cavalca 2023-07-30 20:56:38 UTC
I've imported rust-librsvg and added kalev as admin.

Comment 6 Kalev Lember 2023-07-31 07:27:23 UTC
Sorry, I've been at GUADEC and saw it only now that you were packaging it. I was holding off putting the librsvg crate up for review because upstream is in the process of renaming it from librsvg to rsvg and is just about to upload the first renamed version to crates.io, hopefully later this week. I figured you saw this because your license files PR was marked as related to the rename issue ticket upstream, but I guess not :) Sorry!

Anyway, I think it's fine to have both librsvg and rsvg crates in the distro for now especially if you were in a hurry, but just note that rust-librsvg is likely going to go away in not so distant future and getting replaced by rust-rsvg :)

Adding Fabio just for FYI.

Comment 7 Fabio Valentini 2023-07-31 08:09:55 UTC
It's a bit of unfortunate timing, but I don't think it will create problems.

Once something depends on the new version (i.e. also on the new name), it will just require another package review. Once nothing depends on the old name/version any more, it can be retired. But this can all happen on a leisurely timeline since the packages can coexist without issues.

From my point of view this ticket could be closed for now?

Comment 8 Kalev Lember 2023-07-31 08:29:43 UTC
Yep, agreed on both counts. I'll package rust-rsvg and put it up for review as soon as it's available as I need it for packaging loupe.

Thanks for the help with all this, David and Fabio!

Comment 9 Fedora Update System 2023-08-06 21:01:04 UTC
FEDORA-2023-c2d333f341 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-c2d333f341

Comment 10 Fedora Update System 2023-08-07 01:26:45 UTC
FEDORA-2023-c2d333f341 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.