Bug 2227804
| Summary: | Review Request: libxeddsa - Toolkit around Curve25519 and Ed25519 key pairs | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Matthieu Saulnier <casper> | ||||||
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> | ||||||
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | benson_muite, package-review | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| URL: | https://github.com/Syndace/libxeddsa | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | Type: | --- | |||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 2229922 | ||||||||
| Attachments: |
|
||||||||
|
Description
Matthieu Saulnier
2023-07-31 14:41:02 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/6225769 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2227804-libxeddsa/fedora-rawhide-x86_64/06225769-libxeddsa/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Scratch build: rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=104180340 epel9: https://koji.fedoraproject.org/koji/taskinfo?taskID=104180341 Spec URL: https://fantom.fedorapeople.org/libxeddsa.spec SRPM URL: https://fantom.fedorapeople.org/libxeddsa-2.0.0-2%5e20230730git8ab957a.fc38.src.rpm Scratch build: rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=104226452 (rawhide only, not epel9) Created attachment 1981136 [details]
The .spec file difference from Copr build 6225769 to 6230083
Copr build: https://copr.fedorainfracloud.org/coprs/build/6230083 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2227804-libxeddsa/fedora-rawhide-x86_64/06230083-libxeddsa/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://fantom.fedorapeople.org/libxeddsa.spec SRPM URL: https://fantom.fedorapeople.org/libxeddsa-2.0.0-3%5e20230730git8ab957a.fc38.src.rpm I tried to set manually the soname using the gcc command, but it failed with this error msg: ``` + gcc -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Wl,-soname,libxeddsa.so.0.0.0 -o '/builddir/build/BUILDROOT/libxeddsa-2.0.0-2^20230730git8ab957a.fc38.x86_64/usr/lib64/libxeddsa.so.0.0.0' /usr/bin/ld: /usr/lib/gcc/x86_64-redhat-linux/13/../../../../lib64/crt1.o: in function `_start': (.text+0x1b): undefined reference to `main' collect2: error: ld returned 1 exit status ``` There is one rpmlint warning remaining: E: invalid-soname /usr/lib64/libxeddsa.so.0.0.0 libxeddsa.so (Opening a ticket to upstream) Created attachment 1981382 [details]
The .spec file difference from Copr build 6230083 to 6235898
Copr build: https://copr.fedorainfracloud.org/coprs/build/6235898 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2227804-libxeddsa/fedora-rawhide-x86_64/06235898-libxeddsa/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. A build which generates a shared library can be found at: https://copr.fedorainfracloud.org/coprs/fed500/libxeddsa/build/6260242/ See also https://github.com/Syndace/libxeddsa/pull/6 Doxygen can generate other forms of documentation, for example man pages, not sure if these would be helpful though, but maybe worth checking. Would be helpful to indicate modified and bundled ref10 |