Bug 2227804 - Review Request: libxeddsa - Toolkit around Curve25519 and Ed25519 key pairs
Summary: Review Request: libxeddsa - Toolkit around Curve25519 and Ed25519 key pairs
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/Syndace/libxeddsa
Whiteboard:
Depends On:
Blocks: 2229922
TreeView+ depends on / blocked
 
Reported: 2023-07-31 14:41 UTC by Matthieu Saulnier
Modified: 2023-08-09 12:05 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:


Attachments (Terms of Use)
The .spec file difference from Copr build 6225769 to 6230083 (1.42 KB, patch)
2023-08-01 15:26 UTC, Fedora Review Service
no flags Details | Diff
The .spec file difference from Copr build 6230083 to 6235898 (1.49 KB, patch)
2023-08-03 00:41 UTC, Fedora Review Service
no flags Details | Diff

Description Matthieu Saulnier 2023-07-31 14:41:02 UTC
Spec URL: https://fantom.fedorapeople.org/libxeddsa.spec
SRPM URL: https://fantom.fedorapeople.org/libxeddsa-2.0.0-1%5e20230730git8ab957a.fc38.src.rpm
Description: A toolkit around Curve25519 and Ed25519 key pairs, with a focus on
conversion between the two.

Fedora Account System Username: fantom

Comment 1 Fedora Review Service 2023-07-31 14:47:54 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6225769
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2227804-libxeddsa/fedora-rawhide-x86_64/06225769-libxeddsa/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Fedora Review Service 2023-08-01 15:26:12 UTC
Created attachment 1981136 [details]
The .spec file difference from Copr build 6225769 to 6230083

Comment 5 Fedora Review Service 2023-08-01 15:26:15 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6230083
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2227804-libxeddsa/fedora-rawhide-x86_64/06230083-libxeddsa/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Matthieu Saulnier 2023-08-03 00:36:00 UTC
Spec URL: https://fantom.fedorapeople.org/libxeddsa.spec
SRPM URL: https://fantom.fedorapeople.org/libxeddsa-2.0.0-3%5e20230730git8ab957a.fc38.src.rpm

I tried to set manually the soname using the gcc command, but it failed with this error msg:

```
+ gcc -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Wl,-soname,libxeddsa.so.0.0.0 -o '/builddir/build/BUILDROOT/libxeddsa-2.0.0-2^20230730git8ab957a.fc38.x86_64/usr/lib64/libxeddsa.so.0.0.0'
/usr/bin/ld: /usr/lib/gcc/x86_64-redhat-linux/13/../../../../lib64/crt1.o: in function `_start':
(.text+0x1b): undefined reference to `main'
collect2: error: ld returned 1 exit status
```

There is one rpmlint warning remaining:

E: invalid-soname /usr/lib64/libxeddsa.so.0.0.0 libxeddsa.so

(Opening a ticket to upstream)

Comment 7 Fedora Review Service 2023-08-03 00:41:35 UTC
Created attachment 1981382 [details]
The .spec file difference from Copr build 6230083 to 6235898

Comment 8 Fedora Review Service 2023-08-03 00:41:37 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6235898
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2227804-libxeddsa/fedora-rawhide-x86_64/06235898-libxeddsa/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 9 Benson Muite 2023-08-09 12:05:56 UTC
A build which generates a shared library can be found at:
https://copr.fedorainfracloud.org/coprs/fed500/libxeddsa/build/6260242/
See also https://github.com/Syndace/libxeddsa/pull/6

Doxygen can generate other forms of documentation, for example man pages,
not sure if these would be helpful though, but maybe worth checking.

Would be helpful to indicate modified and bundled ref10


Note You need to log in before you can comment on or make changes to this bug.