Bug 2231007
| Summary: | Review Request: rust-zerocopy-derive - Custom derive for traits from the zerocopy crate | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jakub Čajka <jcajka> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | ASSIGNED --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review?
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://crates.io/crates/zerocopy-derive | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | --- | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2231013 | ||
|
Description
Jakub Čajka
2023-08-10 11:16:01 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/6263156 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2231007-rust-zerocopy/fedora-rawhide-x86_64/06263156-rust-zerocopy-derive/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Build failure is due to the issues with GPG in f39 repos. Two quick comments: 1. If you disable the %check bcond, then un-pinning trybuild is not necessary. dev-dependencies are not included in generated BuildRequires when the check bcond is turned off. So you can just drop the patch in this case. 2. "rm -rf Cargo.lock" in %prep looks weird, and should be unnecessary. The %cargo_prep macro should already do this. Thank you for quick comments. I would like to keep the trybuild patch, if that is non issues, like it breaks some tools/scripts that are used for the rust packaging. Sorry for the left over rm statement and typos, all fixed in the recent build. Spec URL: https://download.copr.fedorainfracloud.org/results/jcajka/zerocopy-derive/fedora-rawhide-x86_64/06304619-rust-zerocopy-derive/rust-zerocopy-derive.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jcajka/zerocopy-derive/fedora-rawhide-x86_64/06304619-rust-zerocopy-derive/rust-zerocopy-derive-0.6.3-1.fc40.src.rpm Copr build: https://copr.fedorainfracloud.org/coprs/build/6304659 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2231007-rust-zerocopy-derive/fedora-rawhide-x86_64/06304659-rust-zerocopy-derive/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. |