Spec URL: https://download.copr.fedorainfracloud.org/results/jcajka/zerocopy-derive/fedora-rawhide-x86_64/06260052-rust-zerocopy-derive/rust-zerocopy-derive.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jcajka/zerocopy-derive/fedora-rawhide-x86_64/06260052-rust-zerocopy-derive/rust-zerocopy-derive-0.6.3-1.fc39.src.rpm Description: Custom derive for traits from the zerocopy crate Fedora Account System Username: jcajka
Copr build: https://copr.fedorainfracloud.org/coprs/build/6263156 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2231007-rust-zerocopy/fedora-rawhide-x86_64/06263156-rust-zerocopy-derive/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Build failure is due to the issues with GPG in f39 repos.
Two quick comments: 1. If you disable the %check bcond, then un-pinning trybuild is not necessary. dev-dependencies are not included in generated BuildRequires when the check bcond is turned off. So you can just drop the patch in this case. 2. "rm -rf Cargo.lock" in %prep looks weird, and should be unnecessary. The %cargo_prep macro should already do this.
Thank you for quick comments. I would like to keep the trybuild patch, if that is non issues, like it breaks some tools/scripts that are used for the rust packaging. Sorry for the left over rm statement and typos, all fixed in the recent build. Spec URL: https://download.copr.fedorainfracloud.org/results/jcajka/zerocopy-derive/fedora-rawhide-x86_64/06304619-rust-zerocopy-derive/rust-zerocopy-derive.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jcajka/zerocopy-derive/fedora-rawhide-x86_64/06304619-rust-zerocopy-derive/rust-zerocopy-derive-0.6.3-1.fc40.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/6304659 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2231007-rust-zerocopy-derive/fedora-rawhide-x86_64/06304659-rust-zerocopy-derive/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Thanks for the update, looks good to me now. === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide ! test suite is run and all unit tests pass (reason given) - latest version of the crate is packaged - license matches upstream specification (BSD-2-Clause) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) === Please take care to import the original / unmodified version of the spec file, not the one that was already processed by rpmautospec.
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-zerocopy-derive
https://bodhi.fedoraproject.org/updates/FEDORA-2023-2f017b80fe