Bug 2231207

SAME ISSUE:


Are you sure you need this package? We have golang-github-google-go-github at version 53 in Fedora:

# Generated by go2rpm 1.9.0
# Needs network
%bcond_with check
%global debug_package %{nil}

# https://github.com/google/go-github
%global goipath         github.com/google/go-github
Version:                53.1.0

%gometa

%global goname golang-github-google-go-github

%global goaltipaths     github.com/google/go-github/v53



What I do in most package is switch the import path so it depends on the Fedora Package:


sed -i 's|github.com/google/go-github/v35|github.com/google/go-github|' $(find . -iname '*.go' -type f)



****Usually it works, so unless you need that very specific version, I'd recommend against packaging it.****


Same review:

Clean up this every time you use go2rpm:

%global golicenses      LICENSE github/licenses.go github/licenses_test.go
%global godocs          example AUTHORS CONTRIBUTING.md README.md example\\\
                        scrape/README.md
->

%global golicenses      LICENSE
%global godocs          example AUTHORS CONTRIBUTING.md README.md


%license LICENSE github/licenses.go github/licenses_test.go
%doc example AUTHORS CONTRIBUTING.md README.md example scrape/README.md

->

%license LICENSE
%doc example AUTHORS CONTRIBUTING.md README.md



-> your SPEC name is incorrect.

So I would recommend using a goname to fix the name

%global goname golang-github-google-go-github-32

Otherwise rename the SPEC to follow the computed goname

-> Don't build the binary:

%build
for cmd in github update-urls; do
  %gobuild -o %{gobuilddir}/bin/$(basename $cmd) %{goipath}/$cmd
done

If you need the binaries built, do it in the package we already have which is the latest version.


- License ok
- Latest version packaged
- Builds in mock
- Checks pass
- No rpmlint errors
- Conforms to Go Packaging Guidelines

Package approved.

Please:
 - add commit rights to go-sig after requesting the repo
 - add the package to Koschei in the go-sig group on all branches you are building
 - add the package to release-monitoring.org even if it does not release version