Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://www.flyn.org/SRPMS/golang-github-google-github-32.spec SRPM URL: https://www.flyn.org/SRPMS/golang-github-google-32-32.1.0-1.fc38.src.rpm Description: Go library for accessing the GitHub v3 API Fedora Account System Username: mikep COPR repository: [copr:copr.fedorainfracloud.org:mikep:golang] name=Copr repo for golang owned by mikep baseurl=https://download.copr.fedorainfracloud.org/results/mikep/golang/fedora-$releasever-$basearch/ type=rpm-md skip_if_unavailable=True gpgcheck=1 gpgkey=https://download.copr.fedorainfracloud.org/results/mikep/golang/pubkey.gpg repo_gpgcheck=0 enabled=1 enabled_metadata=1
SAME ISSUE: Are you sure you need this package? We have golang-github-google-go-github at version 53 in Fedora: # Generated by go2rpm 1.9.0 # Needs network %bcond_with check %global debug_package %{nil} # https://github.com/google/go-github %global goipath github.com/google/go-github Version: 53.1.0 %gometa %global goname golang-github-google-go-github %global goaltipaths github.com/google/go-github/v53 What I do in most package is switch the import path so it depends on the Fedora Package: sed -i 's|github.com/google/go-github/v35|github.com/google/go-github|' $(find . -iname '*.go' -type f) ****Usually it works, so unless you need that very specific version, I'd recommend against packaging it.**** Same review: Clean up this every time you use go2rpm: %global golicenses LICENSE github/licenses.go github/licenses_test.go %global godocs example AUTHORS CONTRIBUTING.md README.md example\\\ scrape/README.md -> %global golicenses LICENSE %global godocs example AUTHORS CONTRIBUTING.md README.md %license LICENSE github/licenses.go github/licenses_test.go %doc example AUTHORS CONTRIBUTING.md README.md example scrape/README.md -> %license LICENSE %doc example AUTHORS CONTRIBUTING.md README.md -> your SPEC name is incorrect. So I would recommend using a goname to fix the name %global goname golang-github-google-go-github-32 Otherwise rename the SPEC to follow the computed goname -> Don't build the binary: %build for cmd in github update-urls; do %gobuild -o %{gobuilddir}/bin/$(basename $cmd) %{goipath}/$cmd done If you need the binaries built, do it in the package we already have which is the latest version. - License ok - Latest version packaged - Builds in mock - Checks pass - No rpmlint errors - Conforms to Go Packaging Guidelines Package approved. Please: - add commit rights to go-sig after requesting the repo - add the package to Koschei in the go-sig group on all branches you are building - add the package to release-monitoring.org even if it does not release version
Package was never imported. The ticket status is being reset, since creating the repository will require a fresh approval. Let us know if you're still interested in this package.
Hello, I do realize that this is possibly an old ticket. I am sorry that it hasn't been reviewed yet. Let me trigger the Fedora Review Service to see if the package builds successfully. Hopefully, a green check mark will attract some reviewer. If I am resurrecting an old ticket that you are not interested in anymore, my apologies, feel free to close it. [fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/9819612 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2231207-golang-github-google-32/fedora-rawhide-x86_64/09819612-golang-github-google-32/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Are you still working on this? If so, have you considered https://bugzilla.redhat.com/show_bug.cgi?id=2231207#c1 ? Thanks!
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.