Bug 2231240
| Summary: | Review Request: golang-github-johncgriffin-overflow - Check for int/int64/int32 arithmetic overflow in Golang | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | W. Michael Petullo <mike> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <eclipseo> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | eclipseo, package-review |
| Target Milestone: | --- | Flags: | eclipseo:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-08-20 20:57:40 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
W. Michael Petullo
2023-08-11 05:30:16 UTC
> License: # FIXME Do fix it ? The License is MIT according to the README. License: MIT Also there is no separate LICENCE file. Bother upstream about it. Meanwhile we can do sed -n '/^MIT License/,$p' README.md > LICENSE ================================================================= # Generated by go2rpm 1.9.0 %bcond_without check %global debug_package %{nil} # https://github.com/JohnCGriffin/overflow %global goipath github.com/JohnCGriffin/overflow %global commit 46fa312c352cdb9517817d04f2067d49f418e332 %gometa -f %global common_description %{expand: Check for int/int64/int32 arithmetic overflow in Golang.} %global golicenses LICENSE %global godocs README.md Name: %{goname} Version: 0 Release: %autorelease -p Summary: Check for int/int64/int32 arithmetic overflow in Golang License: MIT URL: %{gourl} Source: %{gosource} %description %{common_description} %gopkg %prep %goprep %autopatch -p1 sed -n '/^MIT License/,$p' README.md > LICENSE %generate_buildrequires %go_generate_buildrequires %install %gopkginstall %if %{with check} %check %gocheck %endif %gopkgfiles %changelog %autochangelog ================================================================ - License NOT ok - Latest version packaged - Builds in mock - Checks pass - No rpmlint errors - DO NOT Conforms to Go Packaging Guidelines Please update the SPEC. Someone else beat me to suggesting the LICENSE file: https://github.com/JohnCGriffin/overflow/pull/5. I updated the specification and source RPM to match your suggestions: Spec URL: https://www.flyn.org/SRPMS/golang-github-johncgriffin-overflow.spec SRPM URL: https://www.flyn.org/SRPMS/golang-github-johncgriffin-overflow-0-0.1.20230805git46fa312.fc38.src.rpm Add the link to https://github.com/JohnCGriffin/overflow/pull/5 above the sed shenanigans - License ok - Latest version packaged - Builds in mock - Checks pass - No rpmlint errors - Conforms to Go Packaging Guidelines Package approved. Please: - add commit rights to go-sig after requesting the repo - add the package to Koschei in the go-sig group on all branches you are building - add the package to release-monitoring.org even if it does not release version The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-johncgriffin-overflow FEDORA-2023-c8491c0eaa has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-c8491c0eaa FEDORA-2023-c8491c0eaa has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. |