Bug 2231240

Summary: Review Request: golang-github-johncgriffin-overflow - Check for int/int64/int32 arithmetic overflow in Golang
Product: [Fedora] Fedora Reporter: W. Michael Petullo <mike>
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <zebob.m>
Status: ASSIGNED --- QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, zebob.m
Target Milestone: ---Flags: zebob.m: fedora-review?
mike: needinfo? (zebob.m)
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description W. Michael Petullo 2023-08-11 05:30:16 UTC 
Spec URL: https://www.flyn.org/SRPMS/golang-github-johncgriffin-overflow.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-github-johncgriffin-overflow-0-0.1.20230805git46fa312.fc38.src.rpm
Description: Check for int/int64/int32 arithmetic overflow in Golang
Fedora Account System Username: mikep

COPR repository:
[copr:copr.fedorainfracloud.org:mikep:golang]
name=Copr repo for golang owned by mikep
baseurl=https://download.copr.fedorainfracloud.org/results/mikep/golang/fedora-$releasever-$basearch/
type=rpm-md
skip_if_unavailable=True
gpgcheck=1
gpgkey=https://download.copr.fedorainfracloud.org/results/mikep/golang/pubkey.gpg
repo_gpgcheck=0
enabled=1
enabled_metadata=1
Comment 1 Robert-André Mauchin 🐧 2023-08-14 19:15:53 UTC 
> License:        # FIXME


Do fix it ? The License is MIT according to the README.

License:        MIT


Also there is no separate LICENCE file. Bother upstream about it.

Meanwhile we can do
sed -n '/^MIT License/,$p' README.md > LICENSE


=================================================================
# Generated by go2rpm 1.9.0
%bcond_without check
%global debug_package %{nil}

# https://github.com/JohnCGriffin/overflow
%global goipath         github.com/JohnCGriffin/overflow
%global commit          46fa312c352cdb9517817d04f2067d49f418e332

%gometa -f

%global common_description %{expand:
Check for int/int64/int32 arithmetic overflow in Golang.}

%global golicenses      LICENSE
%global godocs          README.md

Name:           %{goname}
Version:        0
Release:        %autorelease -p
Summary:        Check for int/int64/int32 arithmetic overflow in Golang

License:        MIT
URL:            %{gourl}
Source:         %{gosource}

%description %{common_description}

%gopkg

%prep
%goprep
%autopatch -p1
sed -n '/^MIT License/,$p' README.md > LICENSE

%generate_buildrequires
%go_generate_buildrequires

%install
%gopkginstall

%if %{with check}
%check
%gocheck
%endif

%gopkgfiles

%changelog
%autochangelog

================================================================



- License NOT ok
- Latest version packaged
- Builds in mock
- Checks pass
- No rpmlint errors
- DO NOT Conforms to Go Packaging Guidelines


Please update the SPEC.
Comment 2 W. Michael Petullo 2023-08-14 23:00:01 UTC 
Someone else beat me to suggesting the LICENSE file: https://github.com/JohnCGriffin/overflow/pull/5. I updated the specification and source RPM to match your suggestions:

Spec URL: https://www.flyn.org/SRPMS/golang-github-johncgriffin-overflow.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-github-johncgriffin-overflow-0-0.1.20230805git46fa312.fc38.src.rpm