Bug 2231240 - Review Request: golang-github-johncgriffin-overflow - Check for int/int64/int32 arithmetic overflow in Golang
Summary: Review Request: golang-github-johncgriffin-overflow - Check for int/int64/int...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-08-11 05:30 UTC by W. Michael Petullo
Modified: 2023-09-28 02:56 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-08-20 20:57:40 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description W. Michael Petullo 2023-08-11 05:30:16 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-github-johncgriffin-overflow.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-github-johncgriffin-overflow-0-0.1.20230805git46fa312.fc38.src.rpm
Description: Check for int/int64/int32 arithmetic overflow in Golang
Fedora Account System Username: mikep

COPR repository:
[copr:copr.fedorainfracloud.org:mikep:golang]
name=Copr repo for golang owned by mikep
baseurl=https://download.copr.fedorainfracloud.org/results/mikep/golang/fedora-$releasever-$basearch/
type=rpm-md
skip_if_unavailable=True
gpgcheck=1
gpgkey=https://download.copr.fedorainfracloud.org/results/mikep/golang/pubkey.gpg
repo_gpgcheck=0
enabled=1
enabled_metadata=1

Comment 1 Robert-André Mauchin 🐧 2023-08-14 19:15:53 UTC
> License:        # FIXME


Do fix it ? The License is MIT according to the README.

License:        MIT


Also there is no separate LICENCE file. Bother upstream about it.

Meanwhile we can do
sed -n '/^MIT License/,$p' README.md > LICENSE


=================================================================
# Generated by go2rpm 1.9.0
%bcond_without check
%global debug_package %{nil}

# https://github.com/JohnCGriffin/overflow
%global goipath         github.com/JohnCGriffin/overflow
%global commit          46fa312c352cdb9517817d04f2067d49f418e332

%gometa -f

%global common_description %{expand:
Check for int/int64/int32 arithmetic overflow in Golang.}

%global golicenses      LICENSE
%global godocs          README.md

Name:           %{goname}
Version:        0
Release:        %autorelease -p
Summary:        Check for int/int64/int32 arithmetic overflow in Golang

License:        MIT
URL:            %{gourl}
Source:         %{gosource}

%description %{common_description}

%gopkg

%prep
%goprep
%autopatch -p1
sed -n '/^MIT License/,$p' README.md > LICENSE

%generate_buildrequires
%go_generate_buildrequires

%install
%gopkginstall

%if %{with check}
%check
%gocheck
%endif

%gopkgfiles

%changelog
%autochangelog

================================================================



- License NOT ok
- Latest version packaged
- Builds in mock
- Checks pass
- No rpmlint errors
- DO NOT Conforms to Go Packaging Guidelines


Please update the SPEC.

Comment 2 W. Michael Petullo 2023-08-14 23:00:01 UTC
Someone else beat me to suggesting the LICENSE file: https://github.com/JohnCGriffin/overflow/pull/5. I updated the specification and source RPM to match your suggestions:

Spec URL: https://www.flyn.org/SRPMS/golang-github-johncgriffin-overflow.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-github-johncgriffin-overflow-0-0.1.20230805git46fa312.fc38.src.rpm

Comment 3 Robert-André Mauchin 🐧 2023-08-20 19:58:18 UTC
Add the link to https://github.com/JohnCGriffin/overflow/pull/5 above the sed shenanigans

- License ok
- Latest version packaged
- Builds in mock
- Checks pass
- No rpmlint errors
- Conforms to Go Packaging Guidelines

Package approved.

Please:
 - add commit rights to go-sig after requesting the repo
 - add the package to Koschei in the go-sig group on all branches you are building
 - add the package to release-monitoring.org even if it does not release version

Comment 4 Fedora Admin user for bugzilla script actions 2023-08-20 20:41:57 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-johncgriffin-overflow

Comment 5 Fedora Update System 2023-08-20 20:57:13 UTC
FEDORA-2023-c8491c0eaa has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-c8491c0eaa

Comment 6 Fedora Update System 2023-08-20 20:57:40 UTC
FEDORA-2023-c8491c0eaa has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.