Bug 2231945

Summary:	Review Request: golang-modernc-sqlite - A port of SQLite/SQLite3 to Go without cgo
Product:	[Fedora] Fedora	Reporter:	W. Michael Petullo <mike>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <eclipseo>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	eclipseo, link, package-review
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-08-20 21:06:09 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2231393, 2231933
Bug Blocks:

Description W. Michael Petullo 2023-08-14 18:11:17 UTC

Spec URL: https://www.flyn.org/SRPMS/golang-modernc-sqlite.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-modernc-sqlite-1.25.0-1.fc38.src.rpm
Description: A port of SQLite/SQLite3 to Go without cgo
Fedora Account System Username: mikep

COPR repository:
[copr:copr.fedorainfracloud.org:mikep:golang]
name=Copr repo for golang owned by mikep
baseurl=https://download.copr.fedorainfracloud.org/results/mikep/golang/fedora-$releasever-$basearch/
type=rpm-md
skip_if_unavailable=True
gpgcheck=1
gpgkey=https://download.copr.fedorainfracloud.org/results/mikep/golang/pubkey.gpg
repo_gpgcheck=0
enabled=1
enabled_metadata=1

Comment 1 Robert-André Mauchin 🐧 2023-08-20 16:40:21 UTC

Multiple problems:

 - Don't include benchmark/README.md on the devel package and the binary

 - I don't think the binary is really needed but in any case you need to rename it to not conflict with the official sqlite

%gobuild -o %{gobuilddir}/bin/sqlite-go %{goipath}


 - Also we don't need these binaries:

for cmd in speedtest1 tpch; do
  %gobuild -o %{gobuilddir}/bin/$(basename $cmd) %{goipath}/$cmd
done

 - Do not glob the entire bindir:

%{_bindir}/sqlite-go



- License ok
- Latest version packaged
- Builds in mock
- Checks pass
- No rpmlint errors
- Conforms to Go Packaging Guidelines

Comment 2 W. Michael Petullo 2023-08-20 19:42:22 UTC

Spec URL: https://www.flyn.org/SRPMS/golang-modernc-sqlite.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-modernc-sqlite-1.25.0-1.fc38.src.rpm

The new revision removes the binaries and benchmark/README.md.

Comment 3 Robert-André Mauchin 🐧 2023-08-20 19:56:01 UTC

- License ok
- Latest version packaged
- Builds in mock
- Checks pass
- No rpmlint errors
- Conforms to Go Packaging Guidelines

Package approved.

Please:
 - add commit rights to go-sig after requesting the repo
 - add the package to Koschei in the go-sig group on all branches you are building
 - add the package to release-monitoring.org even if it does not release version

Comment 4 Fedora Admin user for bugzilla script actions 2023-08-20 20:38:03 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-modernc-sqlite

Comment 5 Fedora Update System 2023-10-04 14:21:40 UTC

FEDORA-2023-e1748b67c8 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-e1748b67c8

Comment 6 Fedora Update System 2023-10-04 15:10:09 UTC

FEDORA-2023-e1748b67c8 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Link Dupont 2023-12-22 14:19:28 UTC

*** Bug 2254063 has been marked as a duplicate of this bug. ***