Bug 2231393 - Review Request: golang-modernc-libc - Runtime services for Go without cgo
Summary: Review Request: golang-modernc-libc - Runtime services for Go without cgo
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2231392
Blocks: 2231928 2231930 2231933 2231945
TreeView+ depends on / blocked
 
Reported: 2023-08-11 13:25 UTC by W. Michael Petullo
Modified: 2023-09-28 02:54 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-08-20 20:28:06 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 6266433 to 6299746 (1.58 KB, patch)
2023-08-15 17:27 UTC, Fedora Review Service
no flags Details | Diff

Description W. Michael Petullo 2023-08-11 13:25:11 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-modernc-libc.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-modernc-libc-1.24.1-1.fc38.src.rpm
Description: Runtime services for Go without cgo
Fedora Account System Username: mikep

COPR repository:
[copr:copr.fedorainfracloud.org:mikep:golang]
name=Copr repo for golang owned by mikep
baseurl=https://download.copr.fedorainfracloud.org/results/mikep/golang/fedora-$releasever-$basearch/
type=rpm-md
skip_if_unavailable=True
gpgcheck=1
gpgkey=https://download.copr.fedorainfracloud.org/results/mikep/golang/pubkey.gpg
repo_gpgcheck=0
enabled=1
enabled_metadata=1

Comment 1 Robert-André Mauchin 🐧 2023-08-15 07:55:49 UTC
Clean up this:

%global golicenses      LICENSE LICENSE-GO honnef.co/go/netdb/LICENSE\\\
                        musl/COPYRIGHT
%global godocs          AUTHORS CONTRIBUTORS README.md\\\
                        honnef.co/go/netdb/README.md musl/README

->

%global golicenses      LICENSE LICENSE-GO LICENSE-honnef\\\
                        COPYRIGHT-musl
%global godocs          AUTHORS CONTRIBUTORS README.md


and :


%license LICENSE LICENSE-GO honnef.co/go/netdb/LICENSE musl/COPYRIGHT
%doc AUTHORS CONTRIBUTORS README.md honnef.co/go/netdb/README.md musl/README

->

%license LICENSE LICENSE-GO LICENSE-honnef COPYRIGHT-musl
%doc AUTHORS CONTRIBUTORS README.md


with:

%prep
%goprep
%autopatch -p1
mv honnef.co/go/netdb/LICENSE LICENSE-honnef
mv musl/COPYRIGHT COPYRIGHT-musl




 - Add the license breakdown:

Name:           %{goname}
Release:        %autorelease
Summary:        C-runtime services for Go without cgo

# BSD-3-Clause: main program
# MIT: musl/ and honnef.co/
License:        BSD-3-Clause AND MIT
URL:            %{gourl}
Source:         %{gosource}


 - Do not glob the entire bindir/

%{_bindir}/libc


Besides, do you really need the binary for any project? Is it wise to include it?

Needinfo me when updated.

Comment 2 W. Michael Petullo 2023-08-15 17:19:01 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-modernc-libc.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-modernc-libc-1.24.1-1.fc38.src.rpm

Followed suggestions above, and removed binary from package. How do I prevent the macros from building the binary package, which includes only documentation?

Comment 3 Fedora Review Service 2023-08-15 17:27:27 UTC
Created attachment 1983424 [details]
The .spec file difference from Copr build 6266433 to 6299746

Comment 4 Robert-André Mauchin 🐧 2023-08-20 19:13:57 UTC
> How do I prevent the macros from building the binary package, which includes only documentation?

Macros or go2rpm? go2rpm has no provision for that, you edit the file manually.


 - Remove v2 in prep:

rm -rfv v2/


- License ok
- Latest version packaged
- Builds in mock
- Checks pass
- No rpmlint errors
- Conforms to Go Packaging Guidelines

Package approved.

Please:
 - add commit rights to go-sig after requesting the repo
 - add the package to Koschei in the go-sig group on all branches you are building
 - add the package to release-monitoring.org even if it does not release version

Comment 5 Fedora Admin user for bugzilla script actions 2023-08-20 20:23:19 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-modernc-libc

Comment 6 Fedora Update System 2023-08-20 20:36:26 UTC
FEDORA-2023-2b44a09773 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-2b44a09773

Comment 7 Fedora Update System 2023-08-20 20:39:46 UTC
FEDORA-2023-2b44a09773 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.