Bug 2232398

Summary: [webui] Mount point assignment reports "Duplicate mount point." after deleting mapping
Product: [Fedora] Fedora Reporter: Jan Stodola <jstodola>
Component: anacondaAssignee: Vojtech Trefny <vtrefny>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: anaconda-maint, awilliam, gmarr, vslavik, vtrefny, w
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard: AcceptedFreezeException AcceptedBlocker
Fixed In Version: anaconda-39.32.1-1.fc39 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-09-01 03:33:21 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2231339, 2143445, 2143446    
Attachments:
Description Flags
reproducer none

Description Jan Stodola 2023-08-16 16:20:59 UTC
The installer gets confused when mount point assignment is used in webui, mount point mappings are configured and then one mapping is removed and configured again. A video will demonstrate it.

Reproducible: Always

Steps to Reproduce:
1. Run a webui installation on a system with pre-existing partitioning (in my case it was a default installation of Fedora 38 Workstation in UEFI mode)
2. Select "Mount point assignment", create mappings for /boot, /, /boot/efi, /home
3. Remove the mapping for /boot/efi
4. Create a new mapping for /boot/efi
Actual Results:  
webui reports "Duplicate mount point." and the device previously selected for /home is de-selected. Next attempts to set the correct device for /boot/efi and /home mount points are not successful, since the selected device is set for both mount points.

Expected Results:  
Able to add a mapping for /boot/efi

Comment 1 Jan Stodola 2023-08-16 16:22:08 UTC
Created attachment 1983635 [details]
reproducer

Comment 2 Adam Williamson 2023-08-17 15:16:22 UTC
I think it's probably worth considering this for a Final blocker (assuming we go ahead with WebUI), it's a close call for me whether it really *is* one.

Comment 3 Vojtech Trefny 2023-08-24 13:59:48 UTC
PR: https://github.com/rhinstaller/anaconda/pull/5077

Comment 4 Adam Williamson 2023-08-24 17:45:09 UTC
Let's also consider this for Beta FE status...

Comment 5 Adam Williamson 2023-08-27 16:17:44 UTC
+3 in https://pagure.io/fedora-qa/blocker-review/issue/1177 , marking accepted Beta FE.

Comment 6 Geoffrey Marr 2023-08-28 19:45:20 UTC
Discussed during the 2023-08-28 blocker review meeting: [0]

The decision to classify this bug as an "AcceptedBlocker (Final)" was made as it violates the following criterion:

"The installer must be able to create and install to any workable partition layout using any file system and/or container format combination offered in a default installer configuration", read as applying to webUI's mount point assignment interface, in the case you need to re-do a mount point.

[0] https://meetbot.fedoraproject.org/fedora-blocker-review/2023-08-28/f39-blocker-review.2023-08-28-16.07.txt

Comment 7 Fedora Update System 2023-08-30 16:10:21 UTC
FEDORA-2023-7b30b63db9 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-7b30b63db9

Comment 8 Fedora Update System 2023-08-31 01:48:23 UTC
FEDORA-2023-7b30b63db9 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-7b30b63db9`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-7b30b63db9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Adam Williamson 2023-09-01 01:22:38 UTC
I think this is resolved. I can't test exactly the same way because /boot/efi is now required on UEFI installs, but I tested with mounts for /var and /home and it seemed to behave correctly.

Comment 10 Fedora Update System 2023-09-01 03:33:21 UTC
FEDORA-2023-7b30b63db9 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.