Bug 2233180

Summary: Review Request: golang-modernc-y - converts .y (yacc) source files to data suitable for a parser generator
Product: [Fedora] Fedora Reporter: W. Michael Petullo <mike>
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <eclipseo>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: eclipseo, package-review
Target Milestone: ---Flags: eclipseo: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-08-30 02:34:44 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2231928    
Attachments:
Description Flags
The .spec file difference from Copr build 6328161 to 6338984 none

Description W. Michael Petullo 2023-08-21 16:16:59 UTC 
Spec URL: https://www.flyn.org/SRPMS/golang-modernc-y.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-modernc-y-1.1.0-1.fc38.src.rpm
Description: Converts .y (yacc) source files to data suitable for a parser generator
Fedora Account System Username: mikep
Comment 1 Robert-André Mauchin 🐧 2023-08-23 18:45:26 UTC 
 - Summary is too long, shorten it:

Summary:        Converts .y (yacc) source files to data suitable for a parser generator


 - We've got various license in the tests:

BSD-3-Clause
---
y-v1.1.0/all_test.go
y-v1.1.0/api.go
y-v1.1.0/LICENSE
y-v1.1.0/y.go
y-v1.1.0/testdata/ok/cc2.y
y-v1.1.0/testdata/ok/expr.y
y-v1.1.0/testdata/ok/go.y
y-v1.1.0/testdata/ok/ql.y
y-v1.1.0/testdata/ok/test.y
y-v1.1.0/testdata/ok/yacc.y

GPL-2.0-only
---
y-v1.1.0/testdata/ok/mysql.y

MIT
---
y-v1.1.0/testdata/ok/5a.y
y-v1.1.0/testdata/ok/6a.y
y-v1.1.0/testdata/ok/8a.y
y-v1.1.0/testdata/ok/cc.y


- Latest version packaged
- Builds in mock
- Checks pass
- No rpmlint errors
- Conforms to Go Packaging Guidelines

Fix the license field and add a comment with the license breakdown.
Comment 2 W. Michael Petullo 2023-08-23 20:30:22 UTC 
Spec URL: https://www.flyn.org/SRPMS/golang-modernc-y.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-modernc-y-1.1.0-1.fc38.src.rpm

- Shorten description
- Update license field
- Add comments with license breakdown
Comment 3 Fedora Review Service 2023-08-23 20:33:26 UTC 
Created attachment 1984893 [details]
The .spec file difference from Copr build 6328161 to 6338984
Comment 4 Robert-André Mauchin 🐧 2023-08-26 11:48:16 UTC 
- License ok
- Latest version packaged
- Builds in mock
- Checks pass
- No rpmlint errors
- Conforms to Go Packaging Guidelines

Package approved.

Please:
 - add commit rights to go-sig after requesting the repo
 - add the package to Koschei in the go-sig group on all branches you are building
 - add the package to release-monitoring.org even if it does not release version
Comment 5 Fedora Admin user for bugzilla script actions 2023-08-26 12:15:22 UTC 
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-modernc-y
Comment 6 Fedora Update System 2023-08-30 02:33:55 UTC 
FEDORA-2023-2306ab96eb has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-2306ab96eb
Comment 7 Fedora Update System 2023-08-30 02:34:44 UTC 
FEDORA-2023-2306ab96eb has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.