Bug 2231928 - Review Request: golang-modernc-ccgo-3 - ccgo is a C compiler targeting Go
Summary: Review Request: golang-modernc-ccgo-3 - ccgo is a C compiler targeting Go
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2231392 2231393 2231451 2233178 2233179 2233180 2233181 2233182 2233184 2233185 2233187 2233188
Blocks: 2231930 2231933
TreeView+ depends on / blocked
 
Reported: 2023-08-14 17:22 UTC by W. Michael Petullo
Modified: 2023-10-03 20:09 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-10-03 20:09:55 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description W. Michael Petullo 2023-08-14 17:22:55 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-modernc-ccgo-3.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-modernc-ccgo-3-3.16.14-1.fc38.src.rpm
Description: ccgo is a C compiler targeting Go
Fedora Account System Username: mikep

COPR repository:
[copr:copr.fedorainfracloud.org:mikep:golang]
name=Copr repo for golang owned by mikep
baseurl=https://download.copr.fedorainfracloud.org/results/mikep/golang/fedora-$releasever-$basearch/
type=rpm-md
skip_if_unavailable=True
gpgcheck=1
gpgkey=https://download.copr.fedorainfracloud.org/results/mikep/golang/pubkey.gpg
repo_gpgcheck=0
enabled=1
enabled_metadata=1

Comment 1 Robert-André Mauchin 🐧 2023-08-20 18:36:13 UTC
 - Bump to 3.6.15

# https://gitlab.com/cznic/ccgo
%global goipath         modernc.org/ccgo/v3
%global forgeurl        https://gitlab.com/cznic/ccgo
Version:                3.16.15
%global tag             v%{version}

 - You need to assess the LICENSE of the testdata in https://gitlab.com/cznic/ccgo/-/tree/v3.16.15/v3/lib/testdata and add them to the License: field. And add a comment with the breakdown

 - you need v4 to package v3:

DEBUG util.py:442:  No matching package to install: 'golang(modernc.org/ccgo/v4/lib)'

and you need v3 to package v4, you need to bootstrap one of these package, probably make a bootstrap on v3, not building the binary and removing main.go in the bootstrap.

Comment 3 Robert-André Mauchin 🐧 2023-09-25 21:26:03 UTC
This shouldn't be here outside of the bootstrap when you're building the binary

%global debug_package %{nil}

Don't fetch de


%build
%if %{without bootstrap}
%gobuild -o %{gobuilddir}/bin/ccgo %{goipath}
%endif

%files
%license LICENSE
%doc AUTHORS CONTRIBUTORS README.md
%if %{without bootstrap}
%{_bindir}/ccgo
%endif


->


%if %{without bootstrap}
%build
%gobuild -o %{gobuilddir}/bin/ccgo %{goipath}
%endif


%if %{without bootstrap}
%files
%license LICENSE
%doc AUTHORS CONTRIBUTORS README.md
%{_bindir}/ccgo
%endif

Comment 4 W. Michael Petullo 2023-09-26 02:09:57 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-modernc-ccgo-3.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-modernc-ccgo-3-3.16.15-1.fc39~bootstrap.src.rpm

- Fix debug_package. (Did I understand you right?
- Widen use of %if %{without bootstrap}

What does "Don't fetch de" mean?

Thank you!

Comment 5 Robert-André Mauchin 🐧 2023-10-03 17:53:29 UTC
- License ok
- Latest version packaged
- Builds in mock
- Checks pass
- No rpmlint errors
- Conforms to Go Packaging Guidelines

Package approved.

Please:
 - add commit rights to go-sig after requesting the repo
 - add the package to Koschei in the go-sig group on all branches you are building
 - add the package to release-monitoring.org even if it does not release version

Comment 6 Fedora Admin user for bugzilla script actions 2023-10-03 18:53:35 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-modernc-ccgo-3


Note You need to log in before you can comment on or make changes to this bug.