Bug 2233185

Summary:	Review Request: golang-modernc-cc-4 - A C99 compiler front end
Product:	[Fedora] Fedora	Reporter:	W. Michael Petullo <mike>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <eclipseo>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	eclipseo, package-review
Target Milestone:	---	Flags:	eclipseo: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-09-26 01:58:32 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2231928

Description W. Michael Petullo 2023-08-21 16:23:41 UTC

Spec URL: https://www.flyn.org/SRPMS/golang-modernc-cc-4.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-modernc-cc-4-3.41.0-1.fc38.src.rpm
Description: A C99 compiler front end
Fedora Account System Username: mikep

Comment 1 Robert-André Mauchin 🐧 2023-08-26 13:02:22 UTC

- Version:                3.41.0

We're packaging the v4, use the latest v4 tag:

Version:                4.13.0

 - No docs, GO-LICENSE, or README.md in v4


%global golicenses      LICENSE
%global godocs          AUTHORS CONTRIBUTORS 

 - copy the files before deleting the root:

%autopatch -p1
cp -aR LICENSE AUTHORS CONTRIBUTORS v4/.
find . ! \( -name v4 -o -name _build \) -maxdepth 1 -exec rm -rvf {} \;
mv v4/* .

Filed this upstream https://gitlab.com/cznic/cc/-/issues/159



- License ok
- Builds in mock
- Checks pass
- No rpmlint errors
- Conforms to Go Packaging Guidelines

Please fix the problems above.

Comment 2 W. Michael Petullo 2023-08-27 14:28:37 UTC

Wow, quick work on upstreaming the documentation change!

Spec URL: https://www.flyn.org/SRPMS/golang-modernc-cc-4.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-modernc-cc-4-4.13.2-1.fc38.src.rpm

- Package latest v4 version
- Make use of upstreamed documentation change
- Drop GO-LICENSE and README.md

Comment 3 Robert-André Mauchin 🐧 2023-09-25 21:20:35 UTC

Package approved.

Comment 4 Fedora Admin user for bugzilla script actions 2023-09-26 01:53:42 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-modernc-cc-4

Comment 5 Fedora Update System 2023-09-26 02:08:25 UTC

FEDORA-2023-f17646df46 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-f17646df46

Comment 6 Fedora Update System 2023-09-26 02:10:50 UTC

FEDORA-2023-f17646df46 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.