Bug 2233187

Summary:	Review Request: golang-modernc-gc-2 - A a Go compiler front end
Product:	[Fedora] Fedora	Reporter:	W. Michael Petullo <mike>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <eclipseo>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	eclipseo, package-review
Target Milestone:	---	Flags:	eclipseo: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-08-30 11:24:04 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2231928

Description W. Michael Petullo 2023-08-21 16:24:35 UTC

Spec URL: https://www.flyn.org/SRPMS/golang-modernc-gc-2.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-modernc-gc-2-2.3.0-1.fc38.src.rpm
Description: A a Go compiler front end
Fedora Account System Username: mikep

Comment 1 Robert-André Mauchin 🐧 2023-08-26 13:58:10 UTC

I've got an error while testing:

Testing    in: /builddir/build/BUILD/gc-v2.3.0/_build/src
         PATH: /builddir/build/BUILD/gc-v2.3.0/_build/bin:/usr/lib64/ccache:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin
       GOPATH: /builddir/build/BUILD/gc-v2.3.0/_build:/usr/share/gocode
  GO111MODULE: off
      command: go test -buildmode pie -compiler gc -ldflags " -X modernc.org/gc/v2/version=2.3.0 -X modernc.org/gc/v2/version.tag=v2.3.0 -extldflags '-Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -Wl,--build-id=sha1 -specs=/usr/lib/rpm/redhat/redhat-package-notes  '"
      testing: modernc.org/gc/v2
modernc.org/gc/v2
PASS
ok  	modernc.org/gc/v2	9.912s
modernc.org/gc/v2
PASS
ok  	modernc.org/gc/v2	10.336s
modernc.org/gc/v2/internal/ebnf
all_test.go:381: TRC FAIL /usr/lib/golang/src/testing/testing.go: /usr/lib/golang/src/testing/testing.go:369:1: "package" package (/usr/lib/golang/src/testing/testing.go:774:5: "else" else), enters 342749, token tests 99784, maxIndex 1645
--- FAIL: TestParse (9.24s)
    all_test.go:313: /usr/lib/golang/src/testing/testing.go:369:1: "package" package (/usr/lib/golang/src/testing/testing.go:774:5: "else" else), enters 342749, token tests 99784, maxIndex 1645
    all_test.go:315: TOTAL files 3,976, tokens 9,400,356, bytes 53,858,478, skip 0, ok 3,975, fails 1
FAIL

just disable it

%if %{with check}
%check
rm -rfv internal/ebnf/all_test.go
%gocheck
%endif


- License ok
- Latest version packaged
- Builds in mock
- No rpmlint errors
- Conforms to Go Packaging Guidelines

Package approved.

Please:
 - add commit rights to go-sig after requesting the repo
 - add the package to Koschei in the go-sig group on all branches you are building
 - add the package to release-monitoring.org even if it does not release version

Comment 2 Fedora Admin user for bugzilla script actions 2023-08-27 14:29:34 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-modernc-gc-2

Comment 3 Fedora Update System 2023-08-30 11:22:47 UTC

FEDORA-2023-66925d8b27 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-66925d8b27

Comment 4 Fedora Update System 2023-08-30 11:25:35 UTC

FEDORA-2023-66925d8b27 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.