Bug 2236156

Summary: [webui] "Use Free Space..." option is not always visible/hidden
Product: [Fedora] Fedora Reporter: Jan Stodola <jstodola>
Component: anacondaAssignee: anaconda-maint
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: anaconda-maint, awilliam, gmarr, kkoukiou, vslavik, w
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard: AcceptedFreezeException
Fixed In Version: anaconda-40.5-1.fc40 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-10-19 09:03:18 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2231339, 2187793    
Attachments:
Description Flags
webui.log
none
Reproducer none

Description Jan Stodola 2023-08-30 13:25:18 UTC 
The "Use free space for the installation" option is sometimes visible (but not usable due to not enough free space) and sometimes hidden, depending on the steps the user does during the installation.

Reproducible: Always

Version:
anaconda-39.32
Fedora-Workstation-Live-x86_64-Rawhide-20230828.n.0.iso

Steps to Reproduce:
1. Start Live ISO in a VM with one empty disk
2. Start the installer
3. Go through the installation steps back and forth, use the wizard on the left side to skip to the beginning...
Actual Results:  
1) The "Use free space for the installation" option is sometimes visible (but not usable due to not enough free space) and sometimes hidden.
2) The "Use free space for the installation" option is visible for a fraction of second before it gets hidden.

Both issues can be seen on a video that will be attached.


Expected Results:  
The "Use free space for the installation" option is either visible or hidden every time if the user doesn't change the disk partitioning.
(I would assume the option is always visible, but disabled if no free space is available. It would make it consistent with the "Mount point assignment" option, which is always visible even when no partitions are available)
Comment 1 Jan Stodola 2023-08-30 13:26:00 UTC 
Created attachment 1986128 [details]
webui.log
Comment 2 Jan Stodola 2023-08-30 13:27:09 UTC 
Created attachment 1986129 [details]
Reproducer
Comment 3 Katerina Koukiou 2023-09-08 13:03:39 UTC 
The 'Use free space for the installation' is expected to be hidden when the selected disk is empty. We don't want to show to the users disabled options, if there is no action that they can do to enable these.  

See commit https://github.com/rhinstaller/anaconda/commit/c772d33bcc6acaf2bf7445afbbc1a16caefb4037

Leaving it up to the designer to close it a 'NOTABUG' or not.
Comment 4 Jan Stodola 2023-09-11 07:45:36 UTC 
(In reply to Katerina Koukiou from comment #3)
> The 'Use free space for the installation' is expected to be hidden when the
> selected disk is empty.

OK, but in such a case it should always be hidden when the disk is empty. Watch the attachment in comment 2, where the option is sometimes hidden and sometimes visible.
Comment 5 Katerina Koukiou 2023-09-11 13:34:25 UTC 
Upstream fix https://github.com/rhinstaller/anaconda/pull/5159
Comment 6 Fedora Blocker Bugs Application 2023-09-11 14:01:54 UTC 
Proposed as a Freeze Exception for 39-beta by Fedora user kkoukiou using the blocker tracking app because:

 Without this users are prevented from going back after choosing 'Use free space for installation' scenario, if they have already reached the 'Review screen' before doing so.

The PR fixing the bug contains a test.
Comment 7 Geoffrey Marr 2023-09-11 18:15:47 UTC 
Discussed during the 2023-09-11 blocker review meeting: [0]

The decision to classify this bug as an "AcceptedFreezeException (Beta)" was made as it is a noticeable issue that cannot be fixed with an update.

[0] https://meetbot.fedoraproject.org/fedora-blocker-review/2023-09-11/f39-blocker-review.2023-09-11-16.00.txt
Comment 8 Adam Williamson 2023-09-12 22:19:06 UTC 
As webUI has been deferred to F40, deferring the FE status of this bug.