Bug 2237325
| Summary: | Review Request: libtexprintf - Formatted Output with tex-like syntax support | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Benson Muite <benson_muite> |
| Component: | Package Review | Assignee: | Zephyr Lykos <fedora> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | fedora, package-review |
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Linux | ||
| URL: | https://github.com/bartp5/libtexprintf | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-10-13 01:33:14 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Benson Muite
2023-09-04 20:08:29 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/6371760 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2237325-libtexprintf/fedora-rawhide-x86_64/06371760-libtexprintf/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. - automake already requires autoconf, so that's redundant - consider separating the executables into a -tools subpackage - the summary field for -devel subpackage seems wrong? - as the patch is already merged upstream, consider using forge macros and specifying the commit https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_using_forges_hosted_revision_control - use `autoreconf -i` instead of supplied autogen.sh - use plain `%configure` without args and provide the static library in -static, if possible https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_static_libraries - automake already requires autoconf, so that's redundant done - consider separating the executables into a -tools subpackage done - the summary field for -devel subpackage seems wrong? Thanks. Fixed. - as the patch is already merged upstream, consider using forge macros and specifying the commit https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_using_forges_hosted_revision_control Left it for now. Can drop it on the next release. - use `autoreconf -i` instead of supplied autogen.sh Done. - use plain `%configure` without args and provide the static library in -static, if possible https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_static_libraries Guidelines suggest it is preferable not to include static libraries unless there is a good reason to do so. So, typically do not package them unless there is a dependency that needs the static library. spec: https://download.copr.fedorainfracloud.org/results/fed500/libtexprintf/fedora-39-x86_64/06479780-libtexprintf/libtexprintf.spec srpm: https://download.copr.fedorainfracloud.org/results/fed500/libtexprintf/fedora-39-x86_64/06479780-libtexprintf/libtexprintf-1.25-1.fc39.src.rpm Let's say if a user would like to link their own program to the static library, which I, personally, don't prefer, but still a valid use. We're providing both shared and static library in this case, so I think it's better to include it :) Ok. Updated. Get a lint warning static library without debuginfo. spec: https://download.copr.fedorainfracloud.org/results/fed500/libtexprintf/fedora-39-x86_64/06480521-libtexprintf/libtexprintf.spec srpm: https://download.copr.fedorainfracloud.org/results/fed500/libtexprintf/fedora-39-x86_64/06480521-libtexprintf/libtexprintf-1.25-1.fc39.src.rpm koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=106978150 Last small change:
@@ -46,10 +46,7 @@
%package static
Summary: Static libtexprintf library
-Requires: %{name}%{?_isa} = %{version}-%{release}
-Requires: %{name}-devel = %{version}-%{release}
-Provides: %{name}-static%{?_isa} = %{version}-%{release}
-Provides: %{name}-static = %{version}-%{release}
+Requires: %{name}-devel%{?_isa} = %{version}-%{release}
%description static
Updated. spec: https://download.copr.fedorainfracloud.org/results/fed500/libtexprintf/fedora-39-x86_64/06483943-libtexprintf/libtexprintf.spec srpm: https://download.copr.fedorainfracloud.org/results/fed500/libtexprintf/fedora-39-x86_64/06483943-libtexprintf/libtexprintf-1.25-1.fc39.src.rpm The Pagure repository was created at https://src.fedoraproject.org/rpms/libtexprintf FEDORA-2023-30681a847c has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-30681a847c FEDORA-2023-c121354dde has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-c121354dde FEDORA-2023-fcbb3172a9 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-fcbb3172a9 Thanks. FEDORA-2023-fcbb3172a9 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-fcbb3172a9 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-fcbb3172a9 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-30681a847c has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-30681a847c \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-30681a847c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-c121354dde has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-c121354dde \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-c121354dde See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-fcbb3172a9 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2023-c121354dde has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2023-30681a847c has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. |