Bug 2237325 - Review Request: libtexprintf - Formatted Output with tex-like syntax support
Summary: Review Request: libtexprintf - Formatted Output with tex-like syntax support
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Zephyr Lykos
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/bartp5/libtexprintf
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-09-04 20:08 UTC by Benson Muite
Modified: 2023-11-03 18:29 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-10-13 01:33:14 UTC
Type: ---
Embargoed:
fedora: fedora-review+


Attachments (Terms of Use)

Description Benson Muite 2023-09-04 20:08:29 UTC
spec: https://download.copr.fedorainfracloud.org/results/fed500/libtexprintf/fedora-39-x86_64/06371086-libtexprintf/libtexprintf.spec
srpm: https://download.copr.fedorainfracloud.org/results/fed500/libtexprintf/fedora-39-x86_64/06371086-libtexprintf/libtexprintf-1.25-1.fc39.src.rpm

Description:
The utftex program and underlying libtexprintf library provide tools to
pretty print math in mono-space fonts, using a tex-like syntax. It
produces UTF-8 encoded text. The program was inspired by asciiTeX, and
the improved asciiTeX fork. However, utftex supports much more TeX
syntax and contains extensive Unicode tables to map latex commands
to Unicode symbols. Use libtexprintf/utftex to unlock the math
capabilities of Unicode in mono-space text applications.

Note that how the equations look depends strongly on the font you use.
Naturally, one needs a monospace font with good Unicode support for
the symbols you use. A good monospace font for math is, for example,
JuliaMono.

fas: fed500

Reproducible: Always

Comment 1 Fedora Review Service 2023-09-05 01:17:03 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6371760
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2237325-libtexprintf/fedora-rawhide-x86_64/06371760-libtexprintf/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Zephyr Lykos 2023-09-28 14:23:40 UTC
- automake already requires autoconf, so that's redundant
- consider separating the executables into a -tools subpackage
- the summary field for -devel subpackage seems wrong?
- as the patch is already merged upstream, consider using forge macros and specifying the commit
  https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_using_forges_hosted_revision_control
- use `autoreconf -i` instead of supplied autogen.sh
- use plain `%configure` without args and provide the static library in -static, if possible
  https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_static_libraries

Comment 3 Benson Muite 2023-10-01 20:55:49 UTC
- automake already requires autoconf, so that's redundant
done
- consider separating the executables into a -tools subpackage
done
- the summary field for -devel subpackage seems wrong?
Thanks. Fixed.
- as the patch is already merged upstream, consider using forge macros and specifying the commit
  https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_using_forges_hosted_revision_control
Left it for now. Can drop it on the next release.
- use `autoreconf -i` instead of supplied autogen.sh
Done.
- use plain `%configure` without args and provide the static library in -static, if possible
  https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_static_libraries
Guidelines suggest it is preferable not to include static libraries unless there is a good reason to do so.
So, typically do not package them unless there is a dependency that needs the static library.

spec: https://download.copr.fedorainfracloud.org/results/fed500/libtexprintf/fedora-39-x86_64/06479780-libtexprintf/libtexprintf.spec
srpm: https://download.copr.fedorainfracloud.org/results/fed500/libtexprintf/fedora-39-x86_64/06479780-libtexprintf/libtexprintf-1.25-1.fc39.src.rpm

Comment 4 Benson Muite 2023-10-01 21:05:36 UTC
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=106966574

Comment 5 Zephyr Lykos 2023-10-02 02:35:08 UTC
Let's say if a user would like to link their own program to the static library, which I, personally, don't prefer, but still a valid use.
We're providing both shared and static library in this case, so I think it's better to include it :)

Comment 7 Zephyr Lykos 2023-10-02 07:37:29 UTC
Last small change:

@@ -46,10 +46,7 @@
 
 %package static
 Summary: Static libtexprintf library
-Requires: %{name}%{?_isa} = %{version}-%{release}
-Requires: %{name}-devel = %{version}-%{release}
-Provides: %{name}-static%{?_isa} = %{version}-%{release}
-Provides: %{name}-static = %{version}-%{release}
+Requires: %{name}-devel%{?_isa} = %{version}-%{release}
 
 %description static

Comment 9 Fedora Admin user for bugzilla script actions 2023-10-04 05:26:43 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/libtexprintf

Comment 10 Fedora Update System 2023-10-04 06:17:17 UTC
FEDORA-2023-30681a847c has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-30681a847c

Comment 11 Fedora Update System 2023-10-04 06:30:14 UTC
FEDORA-2023-c121354dde has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-c121354dde

Comment 12 Fedora Update System 2023-10-04 07:24:48 UTC
FEDORA-2023-fcbb3172a9 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-fcbb3172a9

Comment 13 Benson Muite 2023-10-04 07:25:33 UTC
Thanks.

Comment 14 Fedora Update System 2023-10-05 01:18:48 UTC
FEDORA-2023-fcbb3172a9 has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-fcbb3172a9 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-fcbb3172a9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2023-10-05 01:49:18 UTC
FEDORA-2023-30681a847c has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-30681a847c \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-30681a847c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 16 Fedora Update System 2023-10-05 02:29:07 UTC
FEDORA-2023-c121354dde has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-c121354dde \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-c121354dde

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 17 Fedora Update System 2023-10-13 01:33:14 UTC
FEDORA-2023-fcbb3172a9 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 18 Fedora Update System 2023-10-13 01:52:34 UTC
FEDORA-2023-c121354dde has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 19 Fedora Update System 2023-11-03 18:29:09 UTC
FEDORA-2023-30681a847c has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.