Bug 2237820
| Summary: | Review Request: uxplay - AirPlay Unix mirroring server | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Davide Cavalca <davide> |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | ngompa13, package-review |
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://github.com/FDH2/UxPlay | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-09-08 02:40:35 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2218117 | ||
|
Description
Davide Cavalca
2023-09-07 05:16:43 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=105849598 Copr build: https://copr.fedorainfracloud.org/coprs/build/6381380 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2237820-uxplay/fedora-rawhide-x86_64/06381380-uxplay/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Please check that its ALAC implementation is not affected by bug 888224. Unless I'm mistaken, this package doesn't implement an ALAC decoder, it just leverages gstreamer in renderers/audio_renderer_gstreamer.c. There is some logic parsing ALAC packets in lib/raop_rtp.c but it from a quick read it's just passing them through, not decoding them. Review notes: * Package follows packaging guidelines * Package builds and installs properly * Package licensing is correct and license files are collected One suggestion: Consider converting the BRs to pkgconfig() deps as it seems the CMake scripts look for dependencies via pkgconfig Otherwise, this is good to go... PACKAGE APPROVED. The Pagure repository was created at https://src.fedoraproject.org/rpms/uxplay FEDORA-2023-c5afb9be25 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-c5afb9be25 FEDORA-2023-c5afb9be25 has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2023-8bca5ab929 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-8bca5ab929 FEDORA-2023-328d344623 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-328d344623 FEDORA-2023-328d344623 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-328d344623 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-328d344623 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-8bca5ab929 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-8bca5ab929 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-8bca5ab929 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-8bca5ab929 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2023-328d344623 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. |