Bug 2237820 - Review Request: uxplay - AirPlay Unix mirroring server
Summary: Review Request: uxplay - AirPlay Unix mirroring server
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/FDH2/UxPlay
Whiteboard:
Depends On:
Blocks: MultimediaSIG
TreeView+ depends on / blocked
 
Reported: 2023-09-07 05:16 UTC by Davide Cavalca
Modified: 2023-09-17 01:26 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-09-08 02:40:35 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2023-09-07 05:16:43 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/uxplay/uxplay.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/uxplay/uxplay-1.65.3-1.fc40.src.rpm

Description:
An AirPlay2 Mirror and AirPlay2 Audio (but not Video) server that provides
screen-mirroring (with audio) of iOS/MacOS clients in a display window on
the server host (which can be shared using a screen-sharing application);
Apple Lossless Audio (ALAC) (e.g.,iTunes) can be streamed from client to
server in non-mirror mode.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2023-09-07 05:16:46 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=105849598

Comment 2 Fedora Review Service 2023-09-07 05:26:14 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6381380
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2237820-uxplay/fedora-rawhide-x86_64/06381380-uxplay/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Dominik 'Rathann' Mierzejewski 2023-09-07 10:18:22 UTC
Please check that its ALAC implementation is not affected by bug 888224.

Comment 4 Davide Cavalca 2023-09-08 02:02:15 UTC
Unless I'm mistaken, this package doesn't implement an ALAC decoder, it just leverages gstreamer in renderers/audio_renderer_gstreamer.c. There is some logic parsing ALAC packets in lib/raop_rtp.c but it from a quick read it's just passing them through, not decoding them.

Comment 5 Neal Gompa 2023-09-08 02:20:11 UTC
Review notes:

* Package follows packaging guidelines
* Package builds and installs properly
* Package licensing is correct and license files are collected

One suggestion: Consider converting the BRs to pkgconfig() deps as it seems the CMake scripts look for dependencies via pkgconfig

Otherwise, this is good to go...

PACKAGE APPROVED.

Comment 6 Fedora Admin user for bugzilla script actions 2023-09-08 02:23:32 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/uxplay

Comment 7 Fedora Update System 2023-09-08 02:39:42 UTC
FEDORA-2023-c5afb9be25 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-c5afb9be25

Comment 8 Fedora Update System 2023-09-08 02:40:35 UTC
FEDORA-2023-c5afb9be25 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2023-09-08 03:07:23 UTC
FEDORA-2023-8bca5ab929 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-8bca5ab929

Comment 10 Fedora Update System 2023-09-08 03:17:29 UTC
FEDORA-2023-328d344623 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-328d344623

Comment 11 Fedora Update System 2023-09-09 01:50:06 UTC
FEDORA-2023-328d344623 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-328d344623 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-328d344623

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2023-09-09 01:52:15 UTC
FEDORA-2023-8bca5ab929 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-8bca5ab929 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-8bca5ab929

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2023-09-15 18:54:16 UTC
FEDORA-2023-8bca5ab929 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2023-09-17 01:26:00 UTC
FEDORA-2023-328d344623 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.