Bug 2238567

Summary:	Review Request: rust-timeago - Given a Duration, lossily format it like in 'N days ago'
Product:	[Fedora] Fedora	Reporter:	Fabio Valentini <decathorpe>
Component:	Package Review	Assignee:	Michel Lind <michel>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	michel, package-review
Target Milestone:	---	Flags:	michel: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	rust-timeago-0.4.2-1.fc40	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-09-25 17:26:27 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2238264

Description Fabio Valentini 2023-09-12 13:14:23 UTC

Spec URL: https://decathorpe.fedorapeople.org/rust-timeago.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-timeago-0.4.1-1.fc38.src.rpm

Description:
Given a Duration, lossily format it like in 'N days ago'. Parsing it
back to Duration is not supported yet.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2023-09-12 13:14:26 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=106084680

Comment 2 Michel Lind 2023-09-14 21:56:38 UTC

The Apache license text is not present - I'm not sure how serious an issue this is, but otherwise this is good to go

Comment 3 Fabio Valentini 2023-09-14 21:59:18 UTC

Good catch, I somehow missed this when I made the package.
This seems to be an oversight by upstream, I'll file an issue.

Comment 4 Fabio Valentini 2023-09-17 11:47:50 UTC

https://github.com/vi/timeago/issues/30

Comment 5 Fabio Valentini 2023-09-18 21:50:11 UTC

Updated to version 0.4.2. This version includes my PR to fix the missing license file.

Spec URL: https://decathorpe.fedorapeople.org/rust-timeago.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-timeago-0.4.2-1.fc38.src.rpm

Comment 6 Michel Lind 2023-09-25 15:29:48 UTC

Everything else checks out; APPROVED

Comment 7 Fabio Valentini 2023-09-25 17:02:30 UTC

Thanks for the review!

Comment 8 Fedora Admin user for bugzilla script actions 2023-09-25 17:03:25 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-timeago

Comment 9 Fabio Valentini 2023-09-25 17:26:27 UTC

Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-f570a923c2