Bug 2238567 - Review Request: rust-timeago - Given a Duration, lossily format it like in 'N days ago'
Summary: Review Request: rust-timeago - Given a Duration, lossily format it like in 'N...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2238264
TreeView+ depends on / blocked
 
Reported: 2023-09-12 13:14 UTC by Fabio Valentini
Modified: 2023-09-25 17:26 UTC (History)
2 users (show)

Fixed In Version: rust-timeago-0.4.2-1.fc40
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-09-25 17:26:27 UTC
Type: ---
Embargoed:
michel: fedora-review+

Attachments (Terms of Use)

Description Fabio Valentini 2023-09-12 13:14:23 UTC 
Spec URL: https://decathorpe.fedorapeople.org/rust-timeago.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-timeago-0.4.1-1.fc38.src.rpm

Description:
Given a Duration, lossily format it like in 'N days ago'. Parsing it
back to Duration is not supported yet.

Fedora Account System Username: decathorpe
Comment 1 Fabio Valentini 2023-09-12 13:14:26 UTC 
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=106084680
Comment 2 Michel Lind 2023-09-14 21:56:38 UTC 
The Apache license text is not present - I'm not sure how serious an issue this is, but otherwise this is good to go
Comment 3 Fabio Valentini 2023-09-14 21:59:18 UTC 
Good catch, I somehow missed this when I made the package.
This seems to be an oversight by upstream, I'll file an issue.
Comment 4 Fabio Valentini 2023-09-17 11:47:50 UTC 
https://github.com/vi/timeago/issues/30
Comment 5 Fabio Valentini 2023-09-18 21:50:11 UTC 
Updated to version 0.4.2. This version includes my PR to fix the missing license file.

Spec URL: https://decathorpe.fedorapeople.org/rust-timeago.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-timeago-0.4.2-1.fc38.src.rpm
Comment 6 Michel Lind 2023-09-25 15:29:48 UTC 
Everything else checks out; APPROVED
Comment 7 Fabio Valentini 2023-09-25 17:02:30 UTC 
Thanks for the review!
Comment 8 Fedora Admin user for bugzilla script actions 2023-09-25 17:03:25 UTC 
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-timeago
Comment 9 Fabio Valentini 2023-09-25 17:26:27 UTC 
Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-f570a923c2
Note You need to log in before you can comment on or make changes to this bug.