Bug 2239033

Summary:	"Create StorageClass" page is breaking for ceph-csi and ceph-rbd provisioners
Product:	[Red Hat Storage] Red Hat OpenShift Data Foundation	Reporter:	Sanjal Katiyar <skatiyar>
Component:	management-console	Assignee:	Sanjal Katiyar <skatiyar>
Status:	CLOSED ERRATA	QA Contact:	Vishakha Kathole <vkathole>
Severity:	urgent	Docs Contact:
Priority:	unspecified
Version:	4.14	CC:	nthomas, odf-bz-bot
Target Milestone:	---
Target Release:	ODF 4.14.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	4.14.0-141	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:
Clones:	2240767 (view as bug list)		Environment:
Last Closed:	2023-11-08 18:54:31 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2240767

Description Sanjal Katiyar 2023-09-14 20:40:42 UTC

Description of problem (please be detailed as possible and provide log
snippests):
This BZ is dependent upon a bug on OCP side and can be tested once below mentioned tickets are in MODIFIED state:
https://issues.redhat.com/browse/OCPBUGS-18996 (for 4.15/master branch)
https://issues.redhat.com/browse/OCPBUGS-18997 (for 4.14 branch)

There are 3 issues:
1. Page displays runtime type error as soon as ceph-csi provisoner is selected.
2. Default parameters for RBD/CSI based classes are not getting added to the created StorageClass.
3. Form validations are not working correctly as well.

Out of these 3 issues, because of first 2 issues proposing this BZ as a blocker.

For more details check the recording here: https://drive.google.com/drive/folders/14aSJs-lO6HC-2xYFlOTJtCZIQg3ekE85?usp=sharing
"sc_creation_with_provisioner.mp4" and "sc_form_typeerror.mp4".

Version of all relevant components (if applicable): OCP/ODF 4.14

Does this issue impact your ability to continue to work with the product
(please explain in detail what is the user impact)?
yes

Is there any workaround available to the best of your knowledge?
CLI

Rate from 1 - 5 the complexity of the scenario you performed that caused this
bug (1 - very simple, 5 - very complex)?

Can this issue reproducible?
yes

Can this issue reproduce from the UI?
yes

If this is a regression, please provide more details to justify this:
yes, but on OCP side

Steps to Reproduce:
1. Install ODF operator.
2. Create StorageSystem (once dynamic plugin is loaded).
3. Wait for a while for ODF related StorageClasses gets created.
4. Once they are created, go to "Create StorageSystem" form.
5. Switch to provisioners (rbd.csi.ceph) added by ODF dynamic plugin.

Actual results:
Page breaks and other mentioned issue above in the description.

Expected results:
Page should not break.

Additional info:

Comment 5 Sanjal Katiyar 2023-09-14 20:46:27 UTC

PR on OCP side: https://github.com/openshift/console/pull/13153 (needs to be merged in master and backported to release-4.14 as well)
Bugs on OCP side:
https://issues.redhat.com/browse/OCPBUGS-18996 (for 4.15/master branch)
https://issues.redhat.com/browse/OCPBUGS-18997 (for 4.14 branch)


PR on ODF side: https://github.com/red-hat-storage/odf-console/pull/1046 (needs to be merged in master and backported to release-4.14/release-4.14-compatibility as well)

Comment 8 Sanjal Katiyar 2023-09-19 14:07:43 UTC

moving back to POST:
ODF side PRs are merged and backported to 4.14,
PRs on OCP side needs to be merged as well (master PR is tagged and should get merged soon, then we need to backport that to OCP 4.14 as well).

Comment 9 Sanjal Katiyar 2023-09-26 08:38:46 UTC

(In reply to Sanjal Katiyar from comment #8)
> moving back to POST:
> ODF side PRs are merged and backported to 4.14,
> PRs on OCP side needs to be merged as well (master PR is tagged and should
> get merged soon, then we need to backport that to OCP 4.14 as well).

OCP side PRs:
https://github.com/openshift/console/pull/13153 (merged).
https://github.com/openshift/console/pull/13170 (backport for 4.14, needs to be tagged).

Comment 10 Sanjal Katiyar 2023-09-26 11:23:25 UTC

we also need to backport this to 4.13.z (specifically to the "compatibility" branch which runs with OCP 4.14 version)...

Comment 11 Sanjal Katiyar 2023-09-26 12:49:21 UTC

this bug is introduced and fixed in OCP 4.14 + ODF 4.14 so no need for RDT text... we do need it for 4.13.z BZ though (https://bugzilla.redhat.com/show_bug.cgi?id=2240767)

Comment 12 Sanjal Katiyar 2023-09-29 12:43:16 UTC

Moving to MODIFIED, PRs are merged for both OCP/ODF 4.14 release branches. Fix should be available on any OCP build on and after 2023-09-29, so any next/latest OCP 4.14 build should be good for testing.

Comment 16 errata-xmlrpc 2023-11-08 18:54:31 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Red Hat OpenShift Data Foundation 4.14.0 security, enhancement & bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:6832