Bug 2240767 - "Create StorageClass" page is breaking for ceph-csi and ceph-rbd provisioners
Summary: "Create StorageClass" page is breaking for ceph-csi and ceph-rbd provisioners
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenShift Data Foundation
Classification: Red Hat Storage
Component: management-console
Version: 4.14
Hardware: Unspecified
OS: Unspecified
unspecified
urgent
Target Milestone: ---
: ODF 4.13.5
Assignee: Sanjal Katiyar
QA Contact: Vishakha Kathole
URL:
Whiteboard:
Depends On: 2239033
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-09-26 11:32 UTC by Sanjal Katiyar
Modified: 2023-12-13 12:58 UTC (History)
5 users (show)

Fixed In Version: 4.13.5-1
Doc Type: Bug Fix
Doc Text:
Previously, in the web console, the following issues occurred because of the refactoring of storage class related code on the OpenShift (console) side: 1. When ceph-csi or ceph-rbd provisioner was selected, the page displayed runtime type error. 2. The default parameters for RADOS block device (RBD) or container storage interface (CSI) based classes were not getting added to the created storage class. 3. Form validations were not working correctly. With this fix, the issues related to the OpenShift console in the newly refactored code are fixed. Also, a few changes are made on the OpenShift Data Foundation (odf-console) side to make sure the new changes are aligned. As a result, the functionality works without any error.
Clone Of: 2239033
Environment:
Last Closed: 2023-12-13 12:58:17 UTC
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github red-hat-storage odf-console pull 1058 0 None open Bug 2240767: [release-4.13-compatibility] fix Create StorageClass form 2023-09-26 11:35:49 UTC
Red Hat Product Errata RHBA-2023:7775 0 None None None 2023-12-13 12:58:19 UTC

Description Sanjal Katiyar 2023-09-26 11:32:53 UTC
+++ This bug was initially created as a clone of Bug #2239033 +++

Description of problem (please be detailed as possible and provide log
snippests):
This BZ is dependent upon a bug on OCP side and can be tested once below mentioned tickets are in MODIFIED state: 
https://issues.redhat.com/browse/OCPBUGS-18996 (for 4.15/master branch)
https://issues.redhat.com/browse/OCPBUGS-18997 (for 4.14 branch)

There are 3 issues:
1. Page displays runtime type error as soon as ceph-csi provisoner is selected.
2. Default parameters for RBD/CSI based classes are not getting added to the created StorageClass.
3. Form validations are not working correctly as well.

Out of these 3 issues, because of first 2 issues proposing this BZ as a blocker.

For more details check the recording here: https://drive.google.com/drive/folders/14aSJs-lO6HC-2xYFlOTJtCZIQg3ekE85?usp=sharing
"sc_creation_with_provisioner.mp4" and "sc_form_typeerror.mp4".

Version of all relevant components (if applicable): OCP/ODF 4.14


Does this issue impact your ability to continue to work with the product
(please explain in detail what is the user impact)?
yes


Is there any workaround available to the best of your knowledge?
CLI

Rate from 1 - 5 the complexity of the scenario you performed that caused this
bug (1 - very simple, 5 - very complex)?


Can this issue reproducible?
yes


Can this issue reproduce from the UI?
yes

If this is a regression, please provide more details to justify this:
yes, but on OCP side

Steps to Reproduce:
1. Install ODF operator.
2. Create StorageSystem (once dynamic plugin is loaded).
3. Wait for a while for ODF related StorageClasses gets created.
4. Once they are created, go to "Create StorageSystem" form.
5. Switch to provisioners (rbd.csi.ceph) added by ODF dynamic plugin. 


Actual results:
Page breaks and other mentioned issue above in the description.

Expected results:
Page should not break.


Additional info:

--- Additional comment from Sanjal Katiyar on 2023-09-14 20:40:42 UTC ---

OCP recently refactored their code to StorageClasForm, which is affecting odf-console as well. Fix of this issue needs to go both in OCP and ODF. PRs for both OCP and ODF are up, they needs to be reviewed and merged.

--- Additional comment from RHEL Program Management on 2023-09-14 20:40:52 UTC ---

This bug having no release flag set previously, is now set with release flag 'odf‑4.14.0' to '?', and so is being proposed to be fixed at the ODF 4.14.0 release. Note that the 3 Acks (pm_ack, devel_ack, qa_ack), if any previously set while release flag was missing, have now been reset since the Acks are to be set against a release flag.

--- Additional comment from RHEL Program Management on 2023-09-14 20:40:52 UTC ---

Since this bug has severity set to 'urgent', it is being proposed as a blocker for the currently set release flag. Please resolve ASAP.

--- Additional comment from Sanjal Katiyar on 2023-09-14 20:46:12 UTC ---

(In reply to Sanjal Katiyar from comment #1)
> OCP recently refactored their code to StorageClasForm, which is affecting
> odf-console as well. Fix of this issue needs to go both in OCP and ODF. PRs
> for both OCP and ODF are up, they needs to be reviewed and merged.

*refactored their code for the StorageClassForm component...

--- Additional comment from Sanjal Katiyar on 2023-09-14 20:46:27 UTC ---

PR on OCP side: https://github.com/openshift/console/pull/13153 (needs to be merged in master and backported to release-4.14 as well)
Bugs on OCP side:
https://issues.redhat.com/browse/OCPBUGS-18996 (for 4.15/master branch)
https://issues.redhat.com/browse/OCPBUGS-18997 (for 4.14 branch)


PR on ODF side: https://github.com/red-hat-storage/odf-console/pull/1046 (needs to be merged in master and backported to release-4.14/release-4.14-compatibility as well)

--- Additional comment from RHEL Program Management on 2023-09-19 06:12:24 UTC ---

This BZ is being approved for ODF 4.14.0 release, upon receipt of the 3 ACKs (PM,Devel,QA) for the release flag 'odf‑4.14.0

--- Additional comment from RHEL Program Management on 2023-09-19 06:12:24 UTC ---

Since this bug has been approved for ODF 4.14.0 release, through release flag 'odf-4.14.0+', the Target Release is being set to 'ODF 4.14.0

--- Additional comment from Sanjal Katiyar on 2023-09-19 14:07:43 UTC ---

moving back to POST:
ODF side PRs are merged and backported to 4.14,
PRs on OCP side needs to be merged as well (master PR is tagged and should get merged soon, then we need to backport that to OCP 4.14 as well).

--- Additional comment from Sanjal Katiyar on 2023-09-26 08:38:46 UTC ---

(In reply to Sanjal Katiyar from comment #8)
> moving back to POST:
> ODF side PRs are merged and backported to 4.14,
> PRs on OCP side needs to be merged as well (master PR is tagged and should
> get merged soon, then we need to backport that to OCP 4.14 as well).

OCP side PRs:
https://github.com/openshift/console/pull/13153 (merged).
https://github.com/openshift/console/pull/13170 (backport for 4.14, needs to be tagged).

--- Additional comment from Sanjal Katiyar on 2023-09-26 11:23:25 UTC ---

we also need to backport this to 4.13.z (specifically to the "compatibility" branch which runs with OCP 4.14 version)...

Comment 5 Sanjal Katiyar 2023-09-29 12:53:42 UTC
since bug was introduced and fixed both in OCP (console) 4.14, on ODF (odf-console) 4.13 side we only need to send a fix for the release-4.13-compatibility branch (because that's what runs with OCP 4.14).

no need to send a fix to release-4.13 branch of ODF (odf-console), as that will run with OCP (console) 4.13 and we don't have this bug in that version.

Comment 6 Sanjal Katiyar 2023-10-03 05:48:59 UTC
(In reply to Sanjal Katiyar from comment #5)
> since bug was introduced and fixed both in OCP (console) 4.14, on ODF
> (odf-console) 4.13 side we only need to send a fix for the
> release-4.13-compatibility branch (because that's what runs with OCP 4.14).
> 
> no need to send a fix to release-4.13 branch of ODF (odf-console), as that
> will run with OCP (console) 4.13 and we don't have this bug in that version.

proposing for 4.13.4, PR is already up...

Comment 7 Sanjal Katiyar 2023-10-04 12:43:16 UTC
proposing for 4.13.5 now as content for 4.13.4 is already finalised...

Comment 19 errata-xmlrpc 2023-12-13 12:58:17 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Red Hat OpenShift Data Foundation 4.13.5 Bug Fix Update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:7775


Note You need to log in before you can comment on or make changes to this bug.