Bug 2239169
| Summary: | tripleo-common does not honor registry pagination | ||
|---|---|---|---|
| Product: | Red Hat OpenStack | Reporter: | Ina Panova <ipanova> |
| Component: | openstack-tripleo-common | Assignee: | Nobody <nobody> |
| Status: | CLOSED DUPLICATE | QA Contact: | David Rosenfeld <drosenfe> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 16.2 (Train) | CC: | iballou, lbezdick, mburns, ramishra, slinaber, vcojot |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-09-18 03:55:28 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
and the command to run to hit this bugs is `openstack undercloud install` Pagination spec: https://docs.docker.com/registry/spec/api/#pagination-1 *** This bug has been marked as a duplicate of bug 2221618 *** |
Description of problem: Satellite container registry has pagination when tags are being listed. triplo does not follow the Link header: ``` def _inspect(cls, image_url, session=None, default_tag=False): image, tag = cls._image_tag_from_url(image_url) parts = { 'image': image, 'tag': tag } tags_url = cls._build_url( image_url, CALL_TAGS % parts ) tags_r = RegistrySessionHelper.get(session, tags_url, timeout=30) tags = tags_r.json()['tags'] ---snip--- ``` and here ``` def _tags_for_image(cls, image, session): url = cls._image_to_url(image) parts = { 'image': url.path, } tags_url = cls._build_url( url, CALL_TAGS % parts ) r = session.get(tags_url, timeout=30) if r.status_code in (403, 404): return image, [] tags = r.json() return image, tags.get('tags', []) [ipanova@puffy tripleo-common]$ git grep Link tripleo_common/image/image_export.py: LOG.debug('[%s] Linking layers: %s -> %s' % ``` This is(or similar) the logic that it needs implemented https://github.com/pulp/pulp_container/blob/main/pulp_container/app/tasks/sync_stages.py#L338 Version-Release number of selected component (if applicable): RHOSP 16.2.5 $ rpm -qa|grep tripleo.commonopenstack-tripleo-common-containers-11.7.1-2.20230308005004.99d0f05.el8ost.noarchopenstack-tripleo-common-11.7.1-2.20230308005004.99d0f05.el8ost.noarchpython3-tripleo-common-11.7.1-2.20230308005004.99d0f05.el8ost.noarch How reproducible: 100% Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: