Bug 2240186

Summary: Review Request: ocean-sound-theme - Ocean Sound Theme for Plasma
Product: [Fedora] Fedora Reporter: Steve Cossette <farchord>
Component: Package ReviewAssignee: Neal Gompa <ngompa13>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: ngompa13, package-review
Target Milestone: ---Flags: ngompa13: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-09-25 21:47:21 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2235556    

Description Steve Cossette 2023-09-22 10:59:14 UTC 
Spec URL: https://api.nicehomeservices.com/images/temp/ocean-sound-theme.spec
SRPM URL: https://api.nicehomeservices.com/images/temp/ocean-sound-theme-5.27.80^20230906.181324.683acbb-1.fc40.src.rpm
Description: Ocean Sound Theme for Plasma
Fedora Account System Username: farchord
Comment 1 Neal Gompa 2023-09-22 13:06:55 UTC 
Taking this review.
Comment 2 Neal Gompa 2023-09-22 13:08:59 UTC 
> %global cmakever 5.27.80
> [...]
> BuildRequires:  extra-cmake-modules >= %{cmakever}
> BuildRequires:  kf6-rpm-macros >= %{cmakever}
> [...]
> Requires:       kf6-filesystem >= %{cmakever}

This accidentally works today, but it won't work in the future, because Plasma and KF6 versions will not be in sync.

You will need to introduce a %kf6ver macro here for these dependencies to separate the version requirement from the package version.
Comment 3 Steve Cossette 2023-09-22 13:18:51 UTC 
Did not know that. I separated the version for those, and reuploaded the source rpm and spec.
Comment 4 Neal Gompa 2023-09-23 06:55:57 UTC 
> %global kf6ver 5.27.80

This should probably be 5.240.0, no?
Comment 5 Neal Gompa 2023-09-23 06:57:17 UTC 
Based on https://invent.kde.org/plasma/ocean-sound-theme/-/blob/master/CMakeLists.txt?ref_type=heads#L12, it looks like it should be "5.240.0".
Comment 6 Steve Cossette 2023-09-23 11:32:54 UTC 
Oh yeah it's in the cmakelists... Updated.

I also updated the git date that was wrong. Seems I misread October as July. Was a drunk...?

Anyway, all updated.
Comment 7 Neal Gompa 2023-09-24 13:18:51 UTC 
> %global debug_package %{nil}

Noarch packages don't need this.

> %{_datadir}/sounds/ocean

Add a trailing slash here.
Comment 8 Steve Cossette 2023-09-24 13:51:01 UTC 
Done and updated.
Comment 9 Neal Gompa 2023-09-25 20:06:46 UTC 
Review notes:

* Package follows Fedora Packaging Guidelines
* Package builds and installs
* Package licensing is correctly handled
* No serious issues from rpmlint

PACKAGE APPROVED.
Comment 10 Fedora Admin user for bugzilla script actions 2023-09-25 20:11:59 UTC 
The Pagure repository was created at https://src.fedoraproject.org/rpms/ocean-sound-theme