Spec URL: https://api.nicehomeservices.com/images/temp/ocean-sound-theme.spec SRPM URL: https://api.nicehomeservices.com/images/temp/ocean-sound-theme-5.27.80^20230906.181324.683acbb-1.fc40.src.rpm Description: Ocean Sound Theme for Plasma Fedora Account System Username: farchord
Taking this review.
> %global cmakever 5.27.80 > [...] > BuildRequires: extra-cmake-modules >= %{cmakever} > BuildRequires: kf6-rpm-macros >= %{cmakever} > [...] > Requires: kf6-filesystem >= %{cmakever} This accidentally works today, but it won't work in the future, because Plasma and KF6 versions will not be in sync. You will need to introduce a %kf6ver macro here for these dependencies to separate the version requirement from the package version.
Did not know that. I separated the version for those, and reuploaded the source rpm and spec.
> %global kf6ver 5.27.80 This should probably be 5.240.0, no?
Based on https://invent.kde.org/plasma/ocean-sound-theme/-/blob/master/CMakeLists.txt?ref_type=heads#L12, it looks like it should be "5.240.0".
Oh yeah it's in the cmakelists... Updated. I also updated the git date that was wrong. Seems I misread October as July. Was a drunk...? Anyway, all updated.
> %global debug_package %{nil} Noarch packages don't need this. > %{_datadir}/sounds/ocean Add a trailing slash here.
Done and updated.
Review notes: * Package follows Fedora Packaging Guidelines * Package builds and installs * Package licensing is correctly handled * No serious issues from rpmlint PACKAGE APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/ocean-sound-theme