Bug 2240304

Summary:	Review Request: icdiff - Improved colored diff
Product:	[Fedora] Fedora	Reporter:	Justin Zobel <justin.zobel>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	code, ngompa13, package-review
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-11-29 07:04:25 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Justin Zobel 2023-09-23 01:01:19 UTC

SPEC URL: https://1707.io/jz/icdiff.spec
SRPM URL: https://1707.io/jz/icdiff-2.0.7-1.fc39.src.rpm


Reproducible: Always

Comment 1 Neal Gompa 2023-09-23 05:54:12 UTC

Taking this review.

Comment 2 Neal Gompa 2023-09-23 05:57:36 UTC

This spec appears to not comply at all with either variant of the Fedora Python packaging guidelines:

* Current: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/
* Alternative: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_201x/

You might want to try using "pyp2spec" to generate a more compliant spec file for this, as icdiff is on PyPI.

Comment 3 Package Review 2024-09-23 00:45:24 UTC

This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems
that the review is still being working out by you. If this is right, please
respond to this comment clearing the NEEDINFO flag and try to reach out the
submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the
fedora-review flag and reset the assignee, so that a new reviewer can take
this ticket.

Without any reply, this request will shortly be resetted.

Comment 4 Package Review 2024-10-23 00:45:29 UTC

This is an automatic action taken by review-stats script.

The ticket reviewer failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we reset the status and the assignee of this ticket.

Comment 5 Ben Beasley 2024-11-29 06:41:59 UTC

The SRPM and spec URLs now produce 404 errors. Are you still planning to pursue this package review, or should this be closed as NOTABUG? Thanks!