Bug 2240304 - Review Request: icdiff - Improved colored diff
Summary: Review Request: icdiff - Improved colored diff
Keywords:
Status: ASSIGNED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-09-23 01:01 UTC by Justin Zobel
Modified: 2023-09-23 05:57 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
ngompa13: fedora-review?

Attachments (Terms of Use)

Description Justin Zobel 2023-09-23 01:01:19 UTC 
SPEC URL: https://1707.io/jz/icdiff.spec
SRPM URL: https://1707.io/jz/icdiff-2.0.7-1.fc39.src.rpm


Reproducible: Always
Comment 1 Neal Gompa 2023-09-23 05:54:12 UTC 
Taking this review.
Comment 2 Neal Gompa 2023-09-23 05:57:36 UTC 
This spec appears to not comply at all with either variant of the Fedora Python packaging guidelines:

* Current: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/
* Alternative: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_201x/

You might want to try using "pyp2spec" to generate a more compliant spec file for this, as icdiff is on PyPI.
Note You need to log in before you can comment on or make changes to this bug.