Bug 2240673

Summary:	Review Request: kf6-kquickcharts - A QtQuick module providing high-performance charts
Product:	[Fedora] Fedora	Reporter:	Steve Cossette <farchord>
Component:	Package Review	Assignee:	Neal Gompa <ngompa13>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	ngompa13, package-review
Target Milestone:	---	Flags:	ngompa13: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-09-26 00:03:25 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2235556

Description Steve Cossette 2023-09-25 20:25:32 UTC

Spec URL: https://api.nicehomeservices.com/images/temp/kf6-kquickcharts.spec
SRPM URL: https://api.nicehomeservices.com/images/temp/kf6-kquickcharts-5.240.0^20230906.190341.34bbef0-1.fc40.src.rpm
Description: A QtQuick module providing high-performance charts
Fedora Account System Username: farchord

Comment 1 Neal Gompa 2023-09-25 22:44:33 UTC

Taking this review...

Comment 2 Neal Gompa 2023-09-25 22:44:45 UTC

Initial spec review:

> BuildRequires:	appstream

What is this for? It's not in the KF5 version and I don't see anything in the code that needs it.

> BuildRequires:	extra-cmake-modules

This needs ">= %{cmakever}" added to it.

Comment 3 Steve Cossette 2023-09-25 23:18:44 UTC

Done. Will apply the version check to extra-cmake-modules on the other packages too.

Comment 4 Neal Gompa 2023-09-25 23:51:51 UTC

Review notes:

* Package follows Fedora Packaging Guidelines
* Package builds and installs
* Package licensing is correctly handled
* No serious issues from rpmlint

PACKAGE APPROVED.

Comment 5 Fedora Admin user for bugzilla script actions 2023-09-25 23:57:57 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/kf6-kquickcharts