Bug 2240673 - Review Request: kf6-kquickcharts - A QtQuick module providing high-performance charts
Summary: Review Request: kf6-kquickcharts - A QtQuick module providing high-performanc...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kf6-reviews
TreeView+ depends on / blocked
 
Reported: 2023-09-25 20:25 UTC by Steve Cossette
Modified: 2023-10-10 16:15 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-09-26 00:03:25 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+

Attachments (Terms of Use)

Description Steve Cossette 2023-09-25 20:25:32 UTC 
Spec URL: https://api.nicehomeservices.com/images/temp/kf6-kquickcharts.spec
SRPM URL: https://api.nicehomeservices.com/images/temp/kf6-kquickcharts-5.240.0^20230906.190341.34bbef0-1.fc40.src.rpm
Description: A QtQuick module providing high-performance charts
Fedora Account System Username: farchord
Comment 1 Neal Gompa 2023-09-25 22:44:33 UTC 
Taking this review...
Comment 2 Neal Gompa 2023-09-25 22:44:45 UTC 
Initial spec review:

> BuildRequires:	appstream

What is this for? It's not in the KF5 version and I don't see anything in the code that needs it.

> BuildRequires:	extra-cmake-modules

This needs ">= %{cmakever}" added to it.
Comment 3 Steve Cossette 2023-09-25 23:18:44 UTC 
Done. Will apply the version check to extra-cmake-modules on the other packages too.
Comment 4 Neal Gompa 2023-09-25 23:51:51 UTC 
Review notes:

* Package follows Fedora Packaging Guidelines
* Package builds and installs
* Package licensing is correctly handled
* No serious issues from rpmlint

PACKAGE APPROVED.
Comment 5 Fedora Admin user for bugzilla script actions 2023-09-25 23:57:57 UTC 
The Pagure repository was created at https://src.fedoraproject.org/rpms/kf6-kquickcharts
Note You need to log in before you can comment on or make changes to this bug.