Bug 2242271
| Summary: | Change minizip-compat dependency to minizip-ng | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Adam Dobes <adobes> |
| Component: | chromium | Assignee: | Than Ngo <than> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | ljavorsk, spotrh, than, tpopela, yaneti |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | chromium-120.0.6099.62-1.fc40 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-12-06 19:02:38 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2235710 | ||
|
Description
Adam Dobes
2023-10-05 09:18:27 UTC
Hello, The Fedora Change proposal (https://fedoraproject.org/wiki/Changes/MinizipNGTransition) is already being worked on, please escalate this issue. I'm afraid it's not easy to switch it to minizip-ng due to missing header file ioapi.h in minizip-ng-devel. Do you have any idea? Thanks! I've found an issue in upstream Github where it was discussed (https://github.com/zlib-ng/minizip-ng/issues/447) However, I'm also not familiar with chromium, maybe it would be worth to try reach to the upstream to ask them if they could take a look at it, and change the dependency. Could you please do that? Hi Than, Upstream just added a commit where they add the ioapi.h for compatibility: https://github.com/zlib-ng/minizip-ng/commit/0d81d2eaaec82f9f0cf298bdbbb49366bd880d39 I'm already adding it to the minizip-ng-compat-devel, would that be enough for chromium to start building with the minizip-ng-compat? Hi Lukas, sadly it is still not enough to build chromium due missing function unzGetCurrentFileZStreamPos64 which is defined in minizip "extern ZPOS64_T ZEXPORT unzGetCurrentFileZStreamPos64 OF((unzFile file));" We need to have this function back in mz_compat Thanks Thanks Than for the review, I asked the upstream why they don't provide it, when they claim the MZ_COMPAT should be compatible with the canonical zlib's minizip. Also, I can see chromium bundles minizip as well. Is our Fedora chromium package ready to switch to bundled minizip if we don't resolve this by the time of the Fedora change implementation? (In reply to Lukas Javorsky from comment #7) > Also, I can see chromium bundles minizip as well. Is our Fedora chromium > package ready to switch to bundled minizip if we don't resolve this by the > time of the Fedora change implementation? Hi Lukas, yes, it should be built with bundle minizip without any problem Than, please switch chromium to bundled minizip. All other packages have been rebuilt in the side-tag and pushed to Bodhi: https://bodhi.fedoraproject.org/updates/FEDORA-2023-cea7a20e14 Expect the `minizip-compat` package to disappear within a week as zlin-ng transition is on move as well. Hi Jan, i already made this change to build with bundleminizip. Should i build it in rawhide or in side-tag? Hi Than, Please build it in rawhide, the side-tag is not the right place for it. it's now fixed in chromium-120.0.6099.62-1.fc40. |