Bug 2242806

Summary:	Review Request: python-hawkmoth - Sphinx Autodoc for C
Product:	[Fedora] Fedora	Reporter:	Benson Muite <benson_muite>
Component:	Package Review	Assignee:	leigh scott <leigh123linux>
Status:	ASSIGNED ---	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	bgilbert, package-review
Target Milestone:	---	Flags:	xavier: fedora-review?
Target Release:	---
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2242888

Description Benson Muite 2023-10-09 04:59:37 UTC

spec: https://download.copr.fedorainfracloud.org/results/fed500/hawkmoth/fedora-rawhide-x86_64/06506221-python-hawkmoth/hawkmoth.spec
srpm: https://download.copr.fedorainfracloud.org/results/fed500/hawkmoth/fedora-rawhide-x86_64/06506221-python-hawkmoth/python-hawkmoth-0.15.0-1.fc40.src.rpm

description:
Hawkmoth is a minimalistic Sphinx C and C++ Domain autodoc
directive extension to incorporate formatted C and C++ source
code comments written in reStructuredText into Sphinx based
documentation. It uses Clang Python Bindings for parsing, and
generates C and C++ Domain directives for C and C++ API
documentation, and more. In short, Hawkmoth is Sphinx Autodoc
for C/C++.

Hawkmoth aims to be a compelling alternative for documenting
C and C++ projects using Sphinx, mainly through its simplicity
of design, implementation and use.

fas: fed500

Reproducible: Always

Comment 1 Benson Muite 2023-10-09 05:00:18 UTC

Still working on a few issues upstream:
https://github.com/jnikula/hawkmoth/issues/189
but initial comments welcome.

Comment 2 Benson Muite 2024-10-05 14:38:41 UTC

Updated. Upstream issues have been resolved.

spec: https://download.copr.fedorainfracloud.org/results/fed500/hawkmoth/fedora-rawhide-x86_64/08110242-python-hawkmoth/hawkmoth.spec
srpm: https://download.copr.fedorainfracloud.org/results/fed500/hawkmoth/fedora-rawhide-x86_64/08110242-python-hawkmoth/python-hawkmoth-0.18.0-1.fc42.src.rpm

Comment 3 leigh scott 2024-10-05 15:06:00 UTC

Is the source url correct?

$ spectool -g hawkmoth.spec 
Downloading: https://github.com/jnikula/hawkmoth/archive/0.18.0/hawkmoth-0.18.0.tar.gz
Download failed:
404 Client Error: Not Found for url: https://codeload.github.com/jnikula/hawkmoth/tar.gz/0.18.0/hawkmoth-0.18.0
-   0.0 B Elapsed Time: 0:00:00            


INFO: Downloading .spec and .srpm files
INFO: Downloading (Source0): https://github.com/jnikula/hawkmoth/archive/0.18.0/hawkmoth-0.18.0.tar.gz
WARNING: Cannot download url: https://github.com/jnikula/hawkmoth/archive/0.18.0/hawkmoth-0.18.0.tar.gz
INFO: No upstream for (Source0): hawkmoth-0.18.0.tar.gz

Comment 4 Fedora Review Service 2024-10-05 16:41:56 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8110340
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2242806-python-hawkmoth/fedora-rawhide-x86_64/08110340-python-hawkmoth/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Benson Muite 2024-10-07 03:15:57 UTC

Sorry, fixed download path

spec: https://download.copr.fedorainfracloud.org/results/fed500/hawkmoth/fedora-rawhide-x86_64/08112590-python-hawkmoth/hawkmoth.spec
srpm: https://download.copr.fedorainfracloud.org/results/fed500/hawkmoth/fedora-rawhide-x86_64/08112590-python-hawkmoth/python-hawkmoth-0.18.0-1.fc42.src.rpm

Comment 6 Fedora Review Service 2024-10-07 03:18:40 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8112599
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2242806-python-hawkmoth/fedora-rawhide-x86_64/08112599-python-hawkmoth/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 leigh scott 2024-10-10 09:03:19 UTC

Can you address these issues


Issues:
=======
- Package must not depend on deprecated() packages.
  Note: python3-pytest7 is deprecated, you must not depend on it.
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/deprecating-packages/
- Spec file name must match the spec package %{name}, in the format
  %{name}.spec.
  Note: hawkmoth.spec should be python-hawkmoth.spec
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/#_spec_file_naming