Bug 2242848
| Summary: | Review Request: golang-github-task-slim-sprig3 - Useful template functions for Go templates | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mark E. Fuller <mark.e.fuller> |
| Component: | Package Review | Assignee: | Mikel Olasagasti Uranga <mikel> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mikel, package-review, quantum.analyst |
| Target Milestone: | --- | Flags: | mikel:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-11-26 15:00:42 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2219039 | ||
|
Description
Mark E. Fuller
2023-10-09 11:23:48 UTC
This should be renamed without the dash between the version, I believe. And remove %{goname} as well. I think you can update to a new version of go2rpm to follow the new guidelines.
Updated to reflect naming changes: Spec URL: https://download.copr.fedorainfracloud.org/results/fuller/go-task/fedora-rawhide-x86_64/06681906-golang-github-task-slim-sprig3/golang-github-task-slim-sprig3.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/fuller/go-task/fedora-rawhide-x86_64/06681906-golang-github-task-slim-sprig3/golang-github-task-slim-sprig3-3.0.0-1.fc40.src.rpm Copr build: https://copr.fedorainfracloud.org/coprs/build/6681911 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2242848-golang-github-task-slim-sprig3/fedora-rawhide-x86_64/06681911-golang-github-task-slim-sprig3/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. I am not going to go through the whole fedora-review template, as this package uses go2rpm. - [x] The specfile is sane. - [x] License is correct - [x] Builds successfully in mock - [x] Package is installable (checked by fedora-review) - [x] No relevant rpmlint errors - [x] %check section passes - [x] The latest version is packaged - [x] `%goipath` is set correctly - [-] Binaries don't conflict with binaries already in the distribution - [x] The package complies with the Packaging Guidelines. Package approved! On import, don't forget to do the following: - [ ] Add package to release-monitoring.org - [ ] Give go-sig privileges on package - [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket. The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-task-slim-sprig3 FEDORA-2023-9380c6c448 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-9380c6c448 FEDORA-2023-9380c6c448 has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. |