Bug 2242848 - Review Request: golang-github-task-slim-sprig3 - Useful template functions for Go templates
Summary: Review Request: golang-github-task-slim-sprig3 - Useful template functions fo...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mikel Olasagasti Uranga
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2219039
TreeView+ depends on / blocked
 
Reported: 2023-10-09 11:23 UTC by Mark E. Fuller
Modified: 2023-11-26 15:00 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-11-26 15:00:42 UTC
Type: ---
Embargoed:
mikel: fedora-review+


Attachments (Terms of Use)

Comment 1 Elliott Sales de Andrade 2023-11-23 01:54:12 UTC
This should be renamed without the dash between the version, I believe. And remove %{goname} as well. I think you can update to a new version of go2rpm to follow the new guidelines.

Comment 3 Fedora Review Service 2023-11-23 03:30:02 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6681911
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2242848-golang-github-task-slim-sprig3/fedora-rawhide-x86_64/06681911-golang-github-task-slim-sprig3/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Mikel Olasagasti Uranga 2023-11-23 09:32:46 UTC
I am not going to go through the whole fedora-review template, as this package uses go2rpm.

- [x] The specfile is sane.
- [x] License is correct
- [x] Builds successfully in mock
- [x] Package is installable (checked by fedora-review)
- [x] No relevant rpmlint errors
- [x] %check section passes
- [x] The latest version is packaged
- [x] `%goipath` is set correctly
- [-] Binaries don't conflict with binaries already in the distribution
- [x] The package complies with the Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add package to release-monitoring.org
- [ ] Give go-sig privileges on package
- [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket.

Comment 5 Fedora Admin user for bugzilla script actions 2023-11-26 14:38:59 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-task-slim-sprig3

Comment 6 Fedora Update System 2023-11-26 14:57:52 UTC
FEDORA-2023-9380c6c448 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-9380c6c448

Comment 7 Fedora Update System 2023-11-26 15:00:42 UTC
FEDORA-2023-9380c6c448 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.